As part of the module maintainer discussion it has been brought up to move from Visualization to Charts module (https://drupal.org/node/2042157#comment-7809335).
I have a larger patch that will be submitted after Drupal.org's schedule downtime tomorrow which removes the need for Visualization. However when the Visualization module was disabled the Reports dashboard JavaScript broke for toggling between block sections.
This is a cleanup of the module's JavaScript properly utilizing Drupal's JavaScript API.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | commerce_reports-dashboard_js_rewrite_reroll.patch | 3.28 KB | mglaman |
| commerce_reports-dashboard-js-rewrite.patch | 2.91 KB | mglaman |
Comments
Comment #1
mglamanComment #2
mglamanRe-rolling submitted patch to fix section switching. Allows chart toggling, however there is issue on Sales Line Chart. Charts module does not provide public function to resize charts on the fly, like Visualization did. Month and week will render at minimum width.
Comment #3
dpearcefl commentedI'd like to make a new dev release and include the patches that people have tested. Can some folks review this fix?
Comment #4
mglamanI was going to apply all these patches and make dev be dependant on Charts and begin cleanup. However there's an issue where updating the project description downgrades the module to sandbox.
See #2125795: Update of project info by non-vetted user demotes full projects to sandbox status. Once I can update the project description to detail dev will become beta3 and that it does not require Visualization I'll begin comitting to dev so we can test this all out.
Comment #5
aidanlis commentedIf you're going to do a major rewrite e.g. removing the vis library, do you want to bump the major version number instead?
Comment #6
mglamanI suppose a bump to the major version number would make more sense, then that way we could keep 2.x-beta as an other version for existing sites and minimal updates.
aidanlis, this is my first shot at going for a module maintaining role so any insight is great :)
Comment #7
mglamanPlease review the 7.x-4.x release which adds this feature, and note module changes as stated in #2129735: Commerce Reports 4.x Review