Closed (fixed)
Project:
Project issue tracking
Version:
7.x-2.x-dev
Component:
User interface
Priority:
Minor
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
1 Nov 2013 at 16:21 UTC
Updated:
28 Feb 2014 at 01:40 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
longwaveComment #2
longwaveIn the core queue, the components are also capitalised now ("Custom_block.module") where they were not before, yet in the dropdown they are still all lower case.
Comment #3
eliza411 commentedComment #4
wim leersIn #2127143: Inappropriate capitalization of components, I explained how this is also problematic for the "ckeditor.module" component in Drupal core.
Comment #5
ParisLiakos commentedi think components are lowercase now?
Phpunit went back to phpunit :D (similar case with ckeditor)
Comment #6
ParisLiakos commentedah...i see..they are only ucfirst in the right issue block...and this piece of css is the problem:
fairly easy to fix
Comment #7
tim.plunkettAgreed.
Comment #8
ParisLiakos commentedcool, thanks for the patch
Comment #9
xjmOne second before we commit this or anything. I think lowercase actually violates our interface text guidelines. https://drupal.org/style-guide/content Furthermore, Drupal 8 standardizes on Sententce-casing short UI strings like Add, Edit, Delete, etc., and field names in core are already capitalized normally in Drupal 7.
Comment #10
xjmJust read #2 and looked at the patch. Yeah, that CSS should not be happening. Ideally we'd just change the labels for the fields themselves, the actual labels in the field configuration. Edit: So, let's add that change to the existing patch?
Comment #11
wim leers#10: exactly, the labels should just be changed, so that we don't end up with improper capitalization. I think #9 only applies to the status, priority and category fields, not to the component field.
Updated the issue title to reflect the current scope.
Comment #12
xjmAlso, FWIW, it is just a matter of getting used to it. :) E.g. the D8 operations label change was a little distracting at first because I was looking for the lowercase shapes, but once I got used to it I found it actually more scannable.
Comment #13
wim leersYeah, I don't care about anything except the component field honestly. See #2127143: Inappropriate capitalization of components for the rationale.
Comment #14
longwaveThree weeks later I agree I am more used to it now. As it was only me requesting the original change, let's just fix the components.
Comment #15
ParisLiakos commentedso? rtbc again? i got used to priority, status etc too..
but Phpunit and Ckeditor.module are just wrong
Comment #16
xjmI'm also terribly confused now. Can we get a screenshot of this patch in action? :)
Comment #17
wim leers#16: the patch changes the CSS. Which means it removes the capitalization for everything. Because as you said in #10: it's the labels themselves that should be updated to be capitalized, that should not happen through CSS!
So, this patch effectively fixes the problem. That the status/priority/category fields should be capitalized is a *separate* issue.
Comment #18
ParisLiakos commentednot exactly. this css only applies to the Component field ;)
attached before and after screenshots..as you can see once i remove the CSS rule only the Component field is lowercase;)
Comment #19
xjmAwesome, thanks @ParisLiakos!
Comment #20
wim leersOh! I clearly mis-remembered what that patch did. Thanks for the correction, ParisLiakos!
Comment #21
dwwCan't please everyone all the time. ;) webchick wanted this change in the first place:
#2097931: Components look weird not capitalized
I lean towards committing this patch and letting people fix component field values to whatever capitalization makes sense, but I'd at least like to let webchick weigh in here and b) it's *really* low priority compared to everything else we're working on these days.
Thanks,
-Derek
Comment #22
drummCommitted.
Even if we wanted to do this, there are a couple things that could be done better: