Maybe I just need to get used to the changes since the D7 relaunch, but it seems harder to scan the columns now the status, priority and category fields are in sentence case rather than all lower case as they were on D6.

Comments

longwave’s picture

Project: Drupal.org site moderators » [Archive] Drupal.org D7 upgrade QA
Component: Textual improvements » User interface
longwave’s picture

In the core queue, the components are also capitalised now ("Custom_block.module") where they were not before, yet in the dropdown they are still all lower case.

eliza411’s picture

Issue tags: +D.o UX
wim leers’s picture

In #2127143: Inappropriate capitalization of components, I explained how this is also problematic for the "ckeditor.module" component in Drupal core.

ParisLiakos’s picture

i think components are lowercase now?
Phpunit went back to phpunit :D (similar case with ckeditor)

ParisLiakos’s picture

ah...i see..they are only ucfirst in the right issue block...and this piece of css is the problem:

media="all"
.views-field-field-issue-component::first-letter, .field-name-field-issue-component .field-items div::first-letter {
text-transform: capitalize;
}

fairly easy to fix

tim.plunkett’s picture

Project: [Archive] Drupal.org D7 upgrade QA » Project issue tracking
Version: » 7.x-2.x-dev
Status: Active » Needs review
StatusFileSize
new452 bytes

Agreed.

ParisLiakos’s picture

Status: Needs review » Reviewed & tested by the community

cool, thanks for the patch

xjm’s picture

Status: Reviewed & tested by the community » Needs review

One second before we commit this or anything. I think lowercase actually violates our interface text guidelines. https://drupal.org/style-guide/content Furthermore, Drupal 8 standardizes on Sententce-casing short UI strings like Add, Edit, Delete, etc., and field names in core are already capitalized normally in Drupal 7.

xjm’s picture

Just read #2 and looked at the patch. Yeah, that CSS should not be happening. Ideally we'd just change the labels for the fields themselves, the actual labels in the field configuration. Edit: So, let's add that change to the existing patch?

wim leers’s picture

Title: Change status, priority and category fields back to lower case » Change status, priority, category and component fields back to lower case

#10: exactly, the labels should just be changed, so that we don't end up with improper capitalization. I think #9 only applies to the status, priority and category fields, not to the component field.

Updated the issue title to reflect the current scope.

xjm’s picture

Also, FWIW, it is just a matter of getting used to it. :) E.g. the D8 operations label change was a little distracting at first because I was looking for the lowercase shapes, but once I got used to it I found it actually more scannable.

wim leers’s picture

Yeah, I don't care about anything except the component field honestly. See #2127143: Inappropriate capitalization of components for the rationale.

longwave’s picture

Title: Change status, priority, category and component fields back to lower case » Change component fields back to lower case

Three weeks later I agree I am more used to it now. As it was only me requesting the original change, let's just fix the components.

ParisLiakos’s picture

Status: Needs review » Reviewed & tested by the community

so? rtbc again? i got used to priority, status etc too..
but Phpunit and Ckeditor.module are just wrong

xjm’s picture

I'm also terribly confused now. Can we get a screenshot of this patch in action? :)

wim leers’s picture

#16: the patch changes the CSS. Which means it removes the capitalization for everything. Because as you said in #10: it's the labels themselves that should be updated to be capitalized, that should not happen through CSS!

So, this patch effectively fixes the problem. That the status/priority/category fields should be capitalized is a *separate* issue.

ParisLiakos’s picture

not exactly. this css only applies to the Component field ;)
attached before and after screenshots..as you can see once i remove the CSS rule only the Component field is lowercase;)

xjm’s picture

Awesome, thanks @ParisLiakos!

wim leers’s picture

Oh! I clearly mis-remembered what that patch did. Thanks for the correction, ParisLiakos!

dww’s picture

Priority: Normal » Minor
Status: Reviewed & tested by the community » Needs review
Related issues: +#2097931: Components look weird not capitalized

Can't please everyone all the time. ;) webchick wanted this change in the first place:

#2097931: Components look weird not capitalized

I lean towards committing this patch and letting people fix component field values to whatever capitalization makes sense, but I'd at least like to let webchick weigh in here and b) it's *really* low priority compared to everything else we're working on these days.

Thanks,
-Derek

drumm’s picture

Status: Needs review » Fixed

Committed.

Even if we wanted to do this, there are a couple things that could be done better:

  • IIRC, capitalizing in PHP code is better for i18n.
  • Modules should balance their use of custom CSS. Too much and themes will want to override it. This feels like too much.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.