I just wanted to report a small/minor issue related with the install file of the module.

It seems module is not deleting any of the configuration variables upon uninstall.
Currently there is only one: baidu_map_api_key

Basically, we would need to add baidu_map.install with an implementation of hook_uninstall.

Please let me know if you would have any questions on any points/code/aspects mentioned in this ticket, I would surely be glad to provide more information.

Any feedback, comments, question, testing would be highly appreciated.
Thanks in advance.

Comments

xiukun.zhou’s picture

xiukun.zhou commented
Status: Active » Fixed

Quick follow-up on this bug report:

Added new file baidu_map.install with an implementation of hook_uninstall which removes the only current variable added by the module:

<?php
variable_del('baidu_map_api_key');
?>

I went ahead and committed the changes against the 7.x-1.x branch at 9990d2f.

I allowed myself to mark this issue as fixed for now, but feel free to re-open it, or post a new ticket, at any time if you have any further objections with this ticket or related commit 9990d2f (we would surely be happy to hear your feedback).

Please let me know if you would have any further comments, feedback, questions, issues, objections, suggestions or concerns on the commit or this feature request in general, I would be glad to provide more information or explain in more details.

Thanks in advance to everyone for your testing, reviews, feedback and comments on this issue.
Cheers!

xiukun.zhou’s picture

xiukun.zhou commented
Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.