Hide 'Revision log message' field on node/add/*

On the issue edit form this field is present as a "Comment". It is used for both the revision log message and as a body of the comment, which is being automatically generated when you edit an issue. It used to have label "Revision comment". However while testing D7 D.o with people in Prague, we received feedback that the label is confusing and it got renamed to just "Comment".

Re-ordering files to address previous comment. :)

testing D7 D.o with people in Prague, we received feedback that the label is confusing

When making comments, "Revision comment" would be confusing, but it is surprising when actually making changes not to have a log. So taking a closer look, after editing over 10 issues to date, this was the first time that I saw this bit:

Provide an explanation of the changes you are making. This will be used for an auto-generated comment about your edit, and will help others understand your motivations.

It is completely hidden under the Format help text and the Body itself. Maybe if this was dropped to the bottom of the form so that the help text is not slammed in-between fields?

See drupal.org-issue-field-order.png for a quick mockup.

Re: #2. No, I didn't mean that. I am saying that another field is playing the role of "Revision log message" for issues. So original "Revision log message" field is hidden on issue edit form. We should also hide it on the issue add form, because, as you correctly noted, it makes no sense to show it there.

Re: #6. Might be a good idea. Location of the comment field is being discussed here #2120007: Move comment field below issue summary on issue edit form. This should also help a lot #2104275: Collapse Text format descriptions on node edit form.

Initial patch for module project_issues.

Thanks for the patch. However, setting to needs work for a few reasons:

A) There could potentially be multiple node types configured to behave as issues. We can't hard-code project_issue in the name of the alter hook implementation. If we did want that, see project_issue_issue_node_types().

B) However, there's no reason to try to restrict this to issue nodes at all. It's pointless having the 'Create new revision' checkbox and 'Revision log message' text area on *any* node/add/* form.

C) It's silly to do this in contrib at all. #308820: Don't show the revision checkbox when a node is being created is the right solution. Sadly, it'll probably be a long time before that's ever committed, backported, and deployed on d.o.

So, for now, let's just do it in drupalorg.module, do it to all node add forms, and leave a @todo comment pointing to #308820.

Thanks!
-Derek

Moved code to drupalorg.module and hided revision fields on all node add forms.

This should go into drupalorg_form_node_form_alter(), which already alters $form['revision_information']

The code comment should reference #308820, so we have a chance of removing it when we upgrade to Drupal 8.

Fixed. New version.

Committed & deploying

Thanks!:)