Consecutive constraint's regex doesn't work.

New issue queue keeps eating my patch. Here's a link instead. https://gist.github.com/sagotsky/7321750

(Not that this helps drush make...)

erikwebb,

Yeah, it looks like the test needs an update. I wrote a quick script to mimic the test with the original and patched patterns.

// mimic psasword_policy's test cases

$constraint = 2;

$patterns = array(
  'original' => '/(.)[\1]{'.($constraint-1).'}/',   
  'patched' => '/(.)\1{'.($constraint-1).'}/',     
);

foreach ($patterns as $label => $pattern) {
  foreach (array('', 'a', 'ab', 'aba', 'aab', 'aaab') as $password) {
    $status = (!preg_match($pattern, $password)) ? 'pass' : 'fail';
    print "$label '$password' $status \n";
  }
}

Results are identical when the constraint is 1. When I up it to 2, the original pattern lets through 'aab' and 'aaab'.

Updated. Just in case the issue queue continues to be wonky about uploads, here's a gist. https://gist.github.com/sagotsky/7321750#file-password_policy-consecutiv...