While looking at several other modules, such as Google Analytics, or many other JS or Third Party related modules, I thought maybe we could consider prompting an error/warning on the Status report page if any Baidu Map is installed but not configured correctly.
If the Baidu Map API key configuration variable would not be configured yet, then a message would be displayed in the Status report page to let users know about it.
Please let me know if you would have any questions, objections, comments, suggestions, recommendations or concerns on any aspects of this issue, I would be glad to provide more information or explain in more details.
Any questions, feedback, testing, changes, ideas or recommendations would be highly appreciated.
Thanks to all in advance.
Comments
Comment #1
xiukun.zhou commentedQuick follow-up on this feature request:
Added an implementation of a standard API hook: hook_requirements that will display a warning message on the Status report page if the Baidu Map API Key would not have been configured properly.
The same validation rule added at 775bc5b for the Key on the Settings form page was used to validate the requirements, see #2127795-1: Add validation for the Baidu Map API Key.
I went ahead and committed the changes against the 7.x-1.x branch at 35cc234.
I allowed myself to mark this issue as fixed for now, but feel free to re-open it, or post a new ticket, at any time if you have any further objections with this ticket or related commit 35cc234 (we would surely be happy to hear your feedback).
Please let me know if you would have any further comments, feedback, questions, issues, objections, suggestions or concerns on the commit or this feature request in general, I would be glad to provide more information or explain in more details.
Special thanks to @DYdave for his great help suggesting this improvement for the user experience.
Thanks in advance to everyone for your testing, reviews, feedback and comments on this issue.
Cheers!