Integration with the Variable module enables modules, like the Contextual Variables and Configuration builder modules, to expand the functionality of this module, allowing for things like variable switching based on environment or customized configuration pages and more.

Additionally Variables could be integrated with Features module as well for export.

For the Baidu Map module, there is currently only a single variable that could be integrated: the Baidu Map API Key.

Please let me know if you would have any questions, objections, comments, suggestions, recommendations or concerns on any aspects of this feature request, I would be glad to provide more information or explain in more details.

Any questions, feedback, testing, changes, ideas or recommendations would be highly appreciated.
Thanks to all in advance.

Comments

xiukun.zhou’s picture

xiukun.zhou commented
Status: Active » Fixed

Quick follow-up on this feature request:

Added a new file called baidu_map.variable.inc which contains the implementation of two major hooks from the Variable API:

  • baidu_map_variable_info: declaration of the Baidu Map API Key variable introduced by the module, with its corresponding validation callback taken from #2127795-1: Add validation for the Baidu Map API Key, which was committed at 775bc5b.
     
  • baidu_map_variable_group_info to add a new group for the module (Displayed as a vertical tab on the Variables admin page).

I went ahead and committed the changes against the 7.x-1.x branch at 7de5c31.

Since all current Baidu Map variables have been integrated, we might certainly come back to this ticket or create new issues in the future if variables had to be removed/added/changed.

Therefore, I allowed myself to mark this issue as fixed for now, but feel free to re-open it, or post a new ticket, at any time if you have any further objections with this issue or related commit 7de5c31 (we would surely be happy to hear your feedback).

Please let me know if you would have any further comments, feedback, questions, issues, objections, suggestions or concerns on the commit or this feature request in general, I would be glad to provide more information or explain in more details.

Special thanks to @DYdave for coming up with this very useful idea of integration.
Thanks in advance to everyone for your testing, reviews, feedback and comments on this issue.
Cheers!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.