Hi,

I have created 2 fivestar Rating fields, 1 is Editor Rating set to Select list (rated while editing). The other is User Rating set to Stars (rated while viewing). After i edited the content, give the rating and save, the editor rating is showing correctly. However after I rate the user rating and refresh the screen, the editor rating is reset. Could you please help? Thanks.

CommentFileSizeAuthor
#3 fivestar-ratingIsReset-2128711-3.patch4.02 KBwhiteph

Comments

marcoka’s picture

Priority: Normal » Critical

actually i can confirm this with alpha2
ok this happens if you do the following

add a field "rate while editing" and chose tag "vote"
add a field "rate while viewing" and chose tag "vote".

somehow in my install all fields seem to be reset and have "vote" as tag and thats why this is.
but i am pretty sure i created a tag for each field, they still exist but are not assigned anymore. maybe something/update broke it. i dont know.

tested again and the above statement is invalid because i added another field with a tag "foo". it is also reset.

that happens if you vote your own content (in my case admin voted both times)
does happen too if voting user not the user who voted while editing

whiteph’s picture

I also came across this, while looking into Star Display Options Missing from field.

I agree that this is a critical issue.

whiteph’s picture

Assigned: hksuineg » whiteph
Status: Active » Needs review
StatusFileSize
new4.02 KB

Please test this patch.

Status: Needs review » Needs work

The last submitted patch, 3: fivestar-ratingIsReset-2128711-3.patch, failed testing.

whiteph’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: fivestar-ratingIsReset-2128711-3.patch, failed testing.

whiteph’s picture

The patch I posted in #3 passes the tests in my local version, and the failure details seem to have very little to do with my change. The error report shows a MySQL environment failure. Maybe there's a problem on Drupal.org.

whiteph’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: fivestar-ratingIsReset-2128711-3.patch, failed testing.

whiteph’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: fivestar-ratingIsReset-2128711-3.patch, failed testing.

jthorson’s picture

Version: 7.x-2.0-alpha2 » 7.x-2.x-dev
jthorson’s picture

Status: Needs work » Needs review
jthorson’s picture

Test issue was due to the issue version, testing against a release instead of the latest -dev.

whiteph’s picture

@jthorson - thanks!

whiteph’s picture

@hksuineg and @marcoka - are you able to test this patch? Given that it's a critical issue, I'd like to commit this asap. Thanks.

wouser’s picture

I have also confirmed that Patch 3 works successfully. Thank you whiteph!

whiteph’s picture

Status: Needs review » Reviewed & tested by the community

Changed status after comment #17

whiteph’s picture

Status: Reviewed & tested by the community » Fixed

Thanks @wouser

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.