Similar to the "fade" effect added by https://drupal.org/node/1234680, we should also have a "slide" effect.

Patch forthcoming.

CommentFileSizeAuthor
#5 add_slide_jquery_effect-2129567-5.patch937 bytesm4olivei
#1 views_load_more-slide_effect-2108315-1.patch688 bytesbrettbirschbach

Comments

brettbirschbach’s picture

brettbirschbach commented
StatusFileSize
new views_load_more-slide_effect-2108315-1.patch688 bytes
brettbirschbach’s picture

brettbirschbach commented
Status: Active » Needs review
brettbirschbach’s picture

brettbirschbach commented

Note that I purposely removed the t() around 'fade' since it is an untranslated machine name.

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Assigned: brettbirschbach » m4olivei
Status: Needs review » Patch (to be ported)

Assigning to myself for later inclusion.

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
StatusFileSize
new add_slide_jquery_effect-2129567-5.patch937 bytes

Re-roll against the latest dev.

  • m4olivei committed 04c3555 on 7.x-1.x 
    Issue #2129567 by HitmanInWis, m4olivei: Add a jQuery slide effect
m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Status: Patch (to be ported) » Closed (fixed)

Committed to 7.x-1.x. Thanks!

brettbirschbach’s picture

brettbirschbach commented

Just out of curiousity...since I submitted the original patch, and it simply needed to be re-rolled against latest codebase but with no actual code changes, should I be credited as the author of the fix? Not 100% sure how attribution works, but I'd like for my company to get visibility for the fixes I made/helped make.

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented

Humm, looks like I messed up the commit message :(. Sorry about that. I'm not sure hot to go back and fix..

brettbirschbach’s picture

brettbirschbach commented

Ya, not 100% sure how to do it...appreciate if you are able to figure it out. Thanks!