Closed (fixed)
Project:
Address Field
Version:
7.x-1.x-dev
Component:
Address formats
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
7 Nov 2013 at 10:44 UTC
Updated:
19 Dec 2014 at 17:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
ItangSanjana commentedreplace T() to t()
Comment #2
ItangSanjana commentedOops, fixed the standards. Ref: http://nomor.net
Comment #3
badrun commentedIt works. Thank you for the patch.
Suggestion:
The current input format is
Province, Regency/City, Postal code
Address 1
Address 2
Propose input format is
Address 1
Address 2
Province, Regency/City, Postal code
The display format is fine.
Question:
What does the number "31" represent?
How do you get those numbers?
Why it is not like below?
In Indonesia, there is no province abbreviation like America (example: CA for California), so why did you replace it with number?
If you replace the value with a number, when addressfield module is combined with auto entity label module, it will show the number, instead of the province name.
Thanks
Comment #4
ItangSanjana commentedProvince code.
http://www.kemendagri.go.id/pages/profil-daerah/provinsi
BTW About the propose input format, I'll patch this ASAP. thanks for stopping by and the auto entity label info! :))
Comment #5
kscheirerBased on #3.
Comment #6
ItangSanjana commentedBased on #3 + drupal_map_assoc() for render format. For more feature see https://drupal.org/sandbox/is/2129777 there is locality options list now. Enjoy ..
Comment #7
ItangSanjana commentedAdded locality options list.
Comment #8
ItangSanjana commentedComment #9
bojanz commentedWe need to use #6, we can't add the locality list to the module, you will need to provide a plugin in your own module for that.
Issues to resolve:
1) The list in #6 is missing "Aceh".
2) The keys of the provinces need to be ISO codes, as listed on https://en.wikipedia.org/wiki/ISO_3166-2:ID.
So AC => Aceh, BA => Bali, BT => Banten, etc.
3) What are the best labels for "Jakarta DKI" and "Yogyakarta DI"?
Google uses "DKI Jakarta" and "Daerah Istimewa Yogyakarta" (and http://yogyakarta.bps.go.id uses "D.I. Yogyakarta").
Comment #10
ItangSanjana commentedThank you for the review.
1) Fixed. It was Nanggroe Aceh Darussalam, but I prefer ISO 3166-2:ID (shorter and common) so it's Aceh now.
2) Fixed.
3) Fixed. DKI Jakarta (shorter and common) and D.I. Yogyakarta (shorter and common).
Comment #11
ItangSanjana commentedComment #12
bojanz commentedCommitted, thank you!
Comment #14
ItangSanjana commentedMost welcome!