Remove discount inline conditions

Here is the patch that removes Commerce Discount related inline conditions.

Related patch to Commerce Discount will be created next and linked back to here.

Adding reference to #2244969: Add inline conditions from inline_conditions into module. in Commerce Discount queue.

I've tested applying both #2244969 and #2129997 succesfully. Everything I've tested keeps working. Commits here (for inline_conditions) and here (for commerce_discount) if one wants to cherry-pick the commits.

Thanks Ralt!

Only request to maintainers - if you cherry-pick off of the GitHub fork, there isn't commit authorship :/ Not an end of the world thing, but one of those little things that makes it feel worth it.

+++ b/inline_conditions.module
@@ -801,3 +801,14 @@ function inline_conditions_get_info_by_module($module = NULL) {
+
+/**
+ * Options list callback for condition.
+ */
+function _inline_conditions_operator_options() {
+  return array(
+    '<' => t('lower than'),
+    '==' => t('equals'),
+    '>' => t('greater than'),
+  );
+}

This function isn't being used, did it sneak in by accident?

No problem, @goldorak thanks for the commit.

Have a problem when I try to update a rule with an operator :

call_user_func('_inline_conditions_operator_options', Object, 'operator') ui.data.inc:202
RulesDataUIText::inputForm('operator', Array, Array, Object) 
call_user_func(Array, 'operator', Array, Array, Object) ui.core.inc:316
RulesPluginUI->getParameterForm('operator', Array, Array, 'input') ui.core.inc:233
RulesPluginUI->form(Array, Array, Array) ui.core.inc:894
RulesAbstractPluginUI->form(Array, Array, Array) 
call_user_func_array(Array, Array) faces.inc:130
FacesExtendable->__call('form', Array) rules.core.inc:362
RulesExtendable->__call('form', Array) rules.core.inc:1260
RulesPlugin->form(Array, Array, Array) ui.forms.inc:373
rules_ui_edit_element(Array, Array, Object, Object, 'admin/config/workflow/rules/components') 
call_user_func_array('rules_ui_edit_element', Array) form.inc:841
drupal_retrieve_form('rules_ui_edit_element', Array) form.inc:350
drupal_build_form('rules_ui_edit_element', Array) form.inc:130
drupal_get_form('rules_ui_edit_element', Object, Object, 'admin/config/workflow/rules/components') 
call_user_func_array('drupal_get_form', Array) menu.inc:519
menu_execute_active_handler() index.php:21

And see the screenshot, the operator list is empty. Can be considered as major issue if, as it seems to be, it break all rules with operators.

@zmove please open a new issue for that, and to get the most, provide steps to reproduce the issue.

Ok sorry, issue created : #2534972: Rules lost its operator with the latest update

Thank you zmove for cross posting the issue back here.