This is a good module. It would be nice if the configuration settings included an option to rename the Menu title to suit the language for the site.

CommentFileSizeAuthor
#13 mobile_navigation-missing-var-del-2135547-13.patch485 byteslauriii
#8 mobile_navigation-dynamic-menu-label-2135547-8.patch2.99 KBlauriii
#7 mobile_navigation-dynamic-menu-label-2135547.patch2.99 KBoperations
#1 menu_label.patch2.99 KBmddunbar

Comments

mddunbar’s picture

mddunbar commented
Parent issue: » #2135547: Include option to change Menu title
StatusFileSize
new menu_label.patch2.99 KB

Here is a patch that adds an option to the configuration screen to allow you to change the menu label.

mddunbar’s picture

mddunbar commented
Status: Active » Needs review
izmeez’s picture

izmeez commented

The patch works great. It doesn't break anything and the Menu label can be changed. Thanks.

izmeez’s picture

izmeez commented
Status: Needs review » Reviewed & tested by the community
izmeez’s picture

izmeez commented

A further simple improvement might be to add "☰ " to the start of the Menu label. It would be available for those who wish to use it and save them the effort of trying to find the correct utf8 character and those who don't want it can easily delete it.

hwasem’s picture

hwasem commented

This worked well for me, thank you! I used the character ☰ to represent the ☰.

operations’s picture

operations commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new mobile_navigation-dynamic-menu-label-2135547.patch2.99 KB

Nice module! I liked the menu slide effect for sub-levels. @mddunbar I think we need to translate the menu label also. I updated the patch and added the menu_label element in t() function before passing it to javascript. Please review.

Thanks,

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
StatusFileSize
new mobile_navigation-dynamic-menu-label-2135547-8.patch2.99 KB 
+++ mobile_navigation_new/mobile_navigation.admin.inc	2013-11-20 15:55:27.000000000 -0500
@@ -43,6 +43,13 @@ function mobile_navigation_configuration
+  ¶

Removed whitespace

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs review » Closed (fixed)
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Closed (fixed) » Reviewed & tested by the community
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

Commited and pushed, thanks!

x7ian’s picture

x7ian commented
Status: Fixed » Closed (fixed)

Thanks a lot for your ideas and great contribution.
I fixed the way the Drupal.settings.menu_label variable is handled so that it is sent to the mobile menu object at its construction at mobile_navigation.js so that Drupal.settings is not accessed directly from the mobile_menu.js. This is for trying to keep mobile_menu.js isolated from drupal so it is flexible and can be used in other environments.
Also using camel caps(menuLabel) as is the convention for other mobile_navigation settings.

http://drupalcode.org/project/mobile_navigation.git/commit/a7584d0

Thanks again!

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Closed (fixed) » Needs review
StatusFileSize
new mobile_navigation-missing-var-del-2135547-13.patch485 bytes

We are still missing variable_del from install file

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs review » Closed (fixed)

Commited and pushed variable_del fix.

maustyle’s picture

maustyle commented

thanks @hwasem for the ASCII ☰ that shows "☰".
works like a charm.

x7ian’s picture

x7ian commented

Please check the 7.x-2.x Roadmap: https://drupal.org/node/2204499

Its time to test the new version of Mobile Navigation.
This feature and many others included.

izmeez’s picture

izmeez commented

The character to represent image of a menu mentioned in #5, #6, and #15 is still not included in the 7.x-1.x-dev branch.