Closed (fixed)
Project:
Drupal Commons
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
14 Nov 2013 at 13:22 UTC
Updated:
28 Mar 2014 at 09:30 UTC
Jump to comment: Most recent
Comments
Comment #1
japerryComment #2
japerryWhile the patch works just fine, I'm having trouble seeing why the bw widget needs to be dependent on commons_groups. There is an og_group_ref in the code, but there is no direct reference to any of the commons_groups functions. There does need to be an OG requirement as it references groups pretty often (including some OG code)
OG Dependency committed here: http://drupalcode.org/project/commons.git/commit/183a17e
Comment #3
arski commentedline 326 $commons_groups_entity_types = commons_groups_get_group_content_entity_types();
if you disable commons groups and leave commons bw, the site blows up saying that that function doesn't exist :/
Comment #4
arski commentedComment #5
arski commentedPS. I'm not sure that adding the requirement is absolutely necessary here.. maybe just make commons_bw_node_auto_title_instance check if the commons_groups function exists?
Comment #6
japerryIndeed that is correct, sorry for not noticing that. Issue is fixed!
http://drupalcode.org/project/commons.git/commit/6559de5
Comment #8
umtj commentedPlease read up on https://drupal.org/node/1146430 and use --author for commit to git.