Added a dependency for commons_group to commons_bw, not sure why this will not work out of the box.

CommentFileSizeAuthor
depend_group_on_bw.patch459 bytesumtj

Comments

japerry’s picture

japerry
Location KOMK
commented
Assigned: Unassigned » japerry
japerry’s picture

japerry
Location KOMK
commented
Assigned: japerry » Unassigned
Status: Needs review » Postponed (maintainer needs more info)

While the patch works just fine, I'm having trouble seeing why the bw widget needs to be dependent on commons_groups. There is an og_group_ref in the code, but there is no direct reference to any of the commons_groups functions. There does need to be an OG requirement as it references groups pretty often (including some OG code)

OG Dependency committed here: http://drupalcode.org/project/commons.git/commit/183a17e

arski’s picture

arski commented

line 326 $commons_groups_entity_types = commons_groups_get_group_content_entity_types();

if you disable commons groups and leave commons bw, the site blows up saying that that function doesn't exist :/

arski’s picture

arski commented
Status: Postponed (maintainer needs more info) » Needs work
arski’s picture

arski commented

PS. I'm not sure that adding the requirement is absolutely necessary here.. maybe just make commons_bw_node_auto_title_instance check if the commons_groups function exists?

japerry’s picture

japerry
Location KOMK
commented
Status: Needs work » Fixed

Indeed that is correct, sorry for not noticing that. Issue is fixed!

http://drupalcode.org/project/commons.git/commit/6559de5

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

umtj’s picture

umtj commented

Please read up on https://drupal.org/node/1146430 and use --author for commit to git.