Problem/Motivation

Introduce a way to avoid running a queue on cron time.
i.e. in drupal.org webheads does not have access to git, so if a queued versioncontrol sync job is processed during hook_cron, it will fail.

Note: this is already a feature in D8. See commit d9135600c92ecd7d747a386cf612c092e2d3e943

Proposed resolution

To add a new option on the queue array.

Remaining tasks

Patch for D8 and D7.

User interface changes

None.

API changes

A new configuration option, by default opt-in, so current behavior is kept.

CommentFileSizeAuthor
#4 2136369-4.patch1.5 KBmarvil07
#2 2136369-2.patch1.48 KBmarvil07
#1 2136369-1.patch1.47 KBmarvil07

Comments

marvil07’s picture

marvil07 commented
Status: Active » Needs review
StatusFileSize
new 2136369-1.patch1.47 KB

D7 version, NR for bot.

marvil07’s picture

marvil07 commented
Assigned: marvil07 » Unassigned
Issue summary: View changes
StatusFileSize
new 2136369-2.patch1.48 KB

Minor bug in last patch fixed.

D8 is not needed, in D8 queue will be run only if queue defines it. So yep, that feature is already in D8!

sdboyer’s picture

sdboyer commented

i think i'd just make a nit over the key name - 'skip on cron' instead of 'skip cron run'. other than that, i'm prepared to RTBC.

marvil07’s picture

marvil07 commented
StatusFileSize
new 2136369-4.patch1.5 KB

Thanks for the review.

Here the key name changed.

sdboyer’s picture

sdboyer commented
Status: Needs review » Reviewed & tested by the community

great. RTBC.

marvil07’s picture

marvil07 commented
Issue tags: +Drupal.org 7.1

Adding a tag to let other drupal.org maintainers to know about this.

David_Rothstein’s picture

David_Rothstein commented
Title: Provide a way to avoid processing a queue during cron execution » Change notification: Provide a way to avoid processing a queue during cron execution
Version: 7.x-dev » 8.x-dev
Category: Feature request » Task
Priority: Normal » Major
Status: Reviewed & tested by the community » Active
Issue tags: +7.25 release notes, +Needs change record

Committed to 7.x (with a small fix to the code comment on commit) - thanks! http://drupalcode.org/project/drupal.git/commit/e868ee8

So I guess this requires a small update to the existing Drupal 8 change notification at https://drupal.org/node/1537256?

marvil07’s picture

marvil07 commented

@David_Rothstein: thanks for adding this to D7!

I have made an addition on the change notice to reflect the change. Let me know if there is anything else.

David_Rothstein’s picture

David_Rothstein commented
Title: Change notification: Provide a way to avoid processing a queue during cron execution » Provide a way to avoid processing a queue during cron execution
Version: 8.x-dev » 7.x-dev
Category: Task » Feature request
Priority: Major » Normal
Status: Active » Fixed

Looks great, thanks! I just edited it to change the wording a tiny bit (because this is a Drupal 8 change notice, not a Drupal 7 one, so we should still only emphasize the changes that people upgrading from Drupal 7 to Drupal 8 will encounter). But all good now...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Issue tags: -Needs change record