Remove module_load_include() call from NodeController::revisionOverview()

This is a dupe of #2021161: Replace the fallback node listing with a list controller and #1863906: [PP-1] Replace content revision table with a view.
The second one should probably just be done this way, and save the view for later, but the overview one is RTBC.

1. +++ b/core/modules/node/lib/Drupal/node/Controller/NodeController.php
   @@ -109,11 +149,88 @@ public function revisionPageTitle($node_revision) {
   +        $row[] = $this->t('!date by !username', array('!date' => $this->l($this->date->format($revision->revision_timestamp, 'short'), 'node.revision_show', array('node' => $node->id(), 'node_revision' => $revision->vid)), '!username' => drupal_render($username)))
   +          . (($revision->log != '') ? '<p class="revision-log">' . Xss::filter($revision->log) . '</p>' : '');
   ...
   +        $row[] = array('data' => t('!date by !username', array('!date' => $this->l($this->date->format($revision->revision_timestamp, 'short'), 'node.view', array('node' => $node->id())), '!username' => drupal_render($username)))
   +          . (($revision->log != '') ? '<p class="revision-log">' . Xss::filter($revision->log) . '</p>' : ''),
   

   Topic for a follow up: We could do something like

2. +++ b/core/modules/node/lib/Drupal/node/Controller/NodeController.php
   @@ -109,11 +149,88 @@ public function revisionPageTitle($node_revision) {
   +    $revert_permission = (($account->hasPermission("revert $type revisions") || $account->hasPermission('revert all revisions') || $account->hasPermission('administer nodes')) && $node->access('update'));
   +    $delete_permission =  (($account->hasPermission("delete $type revisions") || $account->hasPermission('delete all revisions') || $account->hasPermission('administer nodes')) && $node->access('delete'));
   

   I wonder whether it would make sense to abstract into the node access controller.

3. +++ b/core/modules/node/lib/Drupal/node/Controller/NodeController.php
   @@ -109,11 +149,88 @@ public function revisionPageTitle($node_revision) {
   +      '#attached' => array (
   +        'css' => array(drupal_get_path('module', 'node') . '/css/node.admin.css'),
   +      ),
   

   Can we use a library instead?

As I see, here you introduce DI for this class, but if i am not mistaken, it's not really usable to alter the content of the revisions overview. As the renderable array there is only alterable that way if we replace the callback at routing level.

Otherwise, i reviewed the patch in #6, it's fine. (However if https://drupal.org/node/1863906 will be fixed, it won't be needed)

1. +++ b/core/modules/node/lib/Drupal/node/Controller/NodeController.php
   @@ -109,11 +149,88 @@ public function revisionPageTitle($node_revision) {
   +   * Page callback: Generates an overview table of older revisions of a node.
   

   Well, this is not longer a page callback in strict words.

2. +++ b/core/modules/node/lib/Drupal/node/Controller/NodeController.php
   @@ -109,11 +149,88 @@ public function revisionPageTitle($node_revision) {
   +    // @todo What to do with node_revision_list()?
   

   Mark it as @deprecated for now and remove it in a follow up?

3. +++ b/core/modules/node/lib/Drupal/node/Controller/NodeController.php
   @@ -109,11 +149,88 @@ public function revisionPageTitle($node_revision) {
   +        $row[] = array('data' => t('!date by !username', array('!date' => $this->l($this->date->format($revision->revision_timestamp, 'short'), 'node.view', array('node' => $node->id())), '!username' => drupal_render($username)))
   

   Missing $this->t()

As I see, here you introduce DI for this class, but if i am not mistaken, it's not really usable to alter the content of the revisions overview. As the renderable array there is only alterable that way if we replace the callback at routing level.

Not sure what the point here is. You can still try to be part of the usual page flow and alter the render array OR alter the route, for example with a view.

Perfect

Reroll for #2247991: [May 27] Move all module code from …/lib/Drupal/… to …/src/… for PSR-4.

Committed 68a6ee1 and pushed to 8.x. Thanks!

+++ b/core/modules/node/src/Controller/NodeController.php
@@ -8,15 +8,54 @@
+  protected $database;

@@ -110,11 +149,128 @@ public function revisionPageTitle($node_revision) {
+  public function page(NodeInterface $node) {

These are not used anymore. Filed #2283049: Remove obsolete NodeController::page() method.