Hi,

Problem/Motivation

Social login doesn't work.
I use Google, Twitter, Facebook.
When I click to a social icon on login page a popup is opened and then closed right away.
Drupal log contains one of the following messages depending on used provider:

  • Your application id and secret are required in order to connect to Facebook.
  • Your application key and secret are required in order to connect to Twitter.
  • Your application id and secret are required in order to connect to Google.
  • etc.

But I've already configured provider settings.

Affected version

The module versions: 6.x-2.0, 6.x-2.x
HybridAuth Library: 2.1.2 (latest stable)

Do you have ideas what is happening?

Thanks.

Comments

Konstantin Komelin’s picture

Konstantin Komelin commented

Patched the Oauth library as recommended in README. It's still not working.

duozersk’s picture

duozersk
he/him
Primary language Russian
Location Moscow
commented
Assigned: Unassigned » duozersk
Status: Active » Postponed (maintainer needs more info)

Konstantin,

There is a "Debug mode" checkbox on the module settings page (on the last vertical tab or fieldset). Please enable it and check for the log file created at "temporary file system/hybridauth.debug.log". This log file should contain the dumps of the configuration information HybridAuth gets about the used provider. If it doesn't get your keys - then smth is wrong with delivering it to the library (provided these keys are saved and displayed successfully in the module admin settings).

Thanks
AndyB

Konstantin Komelin’s picture

Konstantin Komelin commented

Thank you Andy I didn't know what debug flag does. But I enabled it right after the first issues.

Fragment of debug dump from log:

{s:6:"Google";a:5:{s:7:"enabled";i:1;s:4:"keys";a:3:{s:2:"id";s:0:"";s:3:"key";s:0:"";s:6:"secret";s:0:"";}
s:5:"scope";s:0:"";s:7:"display";s:5:"popup";s:15:"hauth_return_to";s:20:"/hybridauth/endpoint";}

It seems like:

If it doesn't get your keys - then smth is wrong with delivering it to the library (provided these keys are saved and displayed successfully in the module admin settings).

Konstantin Komelin’s picture

Konstantin Komelin commented
Status: Postponed (maintainer needs more info) » Active
duozersk’s picture

duozersk
he/him
Primary language Russian
Location Moscow
commented

Yep, the keys are delivered as empty values. You should check why it happens - the function that gathers the provider config is hybridauth_get_provider_config() - http://drupalcode.org/project/hybridauth.git/blob/refs/heads/6.x-2.x:/hy... - you might want to set the debug output there to see if it ever gets to this function and what values it gets from the variables.

Thanks
AndyB

Konstantin Komelin’s picture

Konstantin Komelin commented

I've discovered the bug.

My server Nginx changes the case of urls, so that urls like this
http://domain/admin/user/hybridauth/provider/Facebook?destination=admin%2Fuser%2Fhybridauth
become
http://domain/admin/user/hybridauth/provider/facebook?destination=admin%2Fuser%2Fhybridauth

And the fourth part is passed into the hybridauth_admin_provider_settings as $provider_id parameter.

There are some hardcode checks for popular providers like this:

switch ($provider_id) {
    case 'Facebook':

So such condition doesn't work because 'facebook' != 'Facebook'.

First obvious fix is to add:

$provider_id = ucfirst($provider_id);

right at the top of the function.
But it wouldn't totally correct for example for 'MySpace' provider machine name.

The best fix would be to replace machine names of providers with their lowercase equivalents in function hybridauth_providers_list() and then add

$provider_id = lowercase($provider_id);

at the top of the function hybridauth_admin_provider_settings().
What do you think? Is it suitable solution? If so I would provide a patch for D6.

duozersk’s picture

duozersk
he/him
Primary language Russian
Location Moscow
commented

Nope,

The library itself requires provider code names to be like the classes implementing these providers were named (and probably the file names the implementation lives in).
class Hybrid_Providers_LinkedIn extends Hybrid_Provider_Model

So I suppose the only solution is to change nginx config not to change the URLs.

AndyB

Konstantin Komelin’s picture

Konstantin Komelin commented

We could imagine many solutions except that extreme one:

So I suppose the only solution is to change nginx config not to change the URLs.

Okay thanks. I will look at it myself. You may close the issue if you think it 'works as designed'.

Konstantin Komelin’s picture

Konstantin Komelin commented

Found another solution. I suggest sending provider name as GET parameter.
Such links
http://domain/admin/user/hybridauth/provider/Facebook?destination=admin%2Fuser%2Fhybridauth
will be replaced with
http://domain/admin/user/hybridauth/provider?name=Facebook&destination=admin%2Fuser%2Fhybridauth

Server rewrite mechanism doesn't touch parameters because they are case sensitive.

Wdyt?

duozersk’s picture

duozersk
he/him
Primary language Russian
Location Moscow
commented

Konstantin,

I wouldn't go for the URLs change... What about implementing the menu argument loading function that will map even the lower-cased provider names to the needed ones?

AndyB

duozersk’s picture

duozersk
he/him
Primary language Russian
Location Moscow
commented
Status: Active » Fixed

Done it for both D7 and D6.
D7 - http://drupalcode.org/project/hybridauth.git/commit/594e768
D6 - http://drupalcode.org/project/hybridauth.git/commit/d0e90de

Please try the snapshot code and see if it helps.

AndyB

Konstantin Komelin’s picture

Konstantin Komelin commented

Excellent solution Andy!
I've tested it on D6 site. It works fine.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.