[meta] Port to Drupal 8

planning to work on it during DrupalSouth code sprint repo here https://drupal.org/project/2169967

Typo in link mentioned in #1, should be:
https://drupal.org/node/2169967

Hi i was working on the D8 port a bit today. I don't have access to the sandbox so i pushed my changes to github: https://github.com/md-systems/menu_block . Could you please give me access to the sandbox such that i can push my changes? Please consider my changes on github if you work on this until i pushed my changes to the sandbox repo.

Hi
We switched to github, github.com/larowlan/menu_block - can you send a PR against that.

Lee

Ok i created a pull request at https://github.com/larowlan/menu_block/pull/4

cheers

If this is happening in github - is there an update for this issue?

https://github.com/larowlan/menu_block hasn't been changed in the last 11 months, so I doubt it still works with the latest D8. Would be good if we could start actually getting some patches submitted back here instead.

The basic menu_block functionality is now in core, so it's not a straight port. We need to define what features we want in the contrib module.

I also wonder if menu_block could just alter the existing core menu block behavior to support the additional features, or if we have to provide its own plugin and keep them separate. I'd prefer the former if possible.

Config schema is going to make that hard, I don't think it is possible to say that an existing plugin has more configuration keys. There's third party settings, but those are on the config entity and a block plugin shouldn't rely on that (because page manager for example uses and stores block differently).

I recently audited this in core and it seems like a near identical port.

Should there be a notice on the project page about how this functionality has moved into core in D8? I think this would be beneficial for people to see.

Some explanation would be much appreca

I needed the functionality to expand all menu items. Since there is no D8 port of this module yet, I created one which we can hopefully replace later on with menu_block:

https://github.com/axe312ger/expanded_menu_block

Hope thats useful for someone else :)

Is the "expand all children" feature included in the menu_block port to Drupal 8 core? I don't see an option to do that in the blocks.

@axe312: is expanded_menu_block functional with 8.0.1?

@axe312 - any idea on if you'll make that a sandbox - expand all children is exactly what I am after. If menu_block isn't going to get an official port - maybe we need a contrib module of expanded_menu_block or similar. @safetypin I'll try it on a test site and fork and fix on github when I get time (Maybe the January 2016 global sprint weekend on 30/31 Jan 2016)

expanded_menu_block works perfectly. Should we use it as a base for this D8 port?

I just tested the Github module from #14 and that works great. Thank you @axe312.

Yeah, expanded_menu_block provides an "Expand all childs" ability, however, we still need the the most useful functionality of selecting the "Fixed parent item", as is available in the 7.x version under "Advanced".

Yes, the menu_block in core is stripped of some rather necessary features. Expand + fixed parents is really nice to have from time to time, footer links and sitemaps pages. Larger sites need the follow trail and sort items feature aswell. The moduler should perhaps be named "menu_block_advanced" or something that doesnt excluded featuers in the name.

No, lets not create a new module. menu_block seems to be the right place to do this, right?

Would it make any sense to try and get that feature added to Core? Perhaps for 8.2?

The main features offered by the module (to my mind) is the fixed parent and default to expanded within the block without it needing to be set on the menu. It would be nice to see this in core, but I also think we need an 8.x-1.x release before it is likely to be considered for core (Thinking along the lines of big_pipe). What are others thoughts? Push with 8.x-1.x and try core for 8.2 or beyond? Or just push for core now?

I like the idea of having an 8.x-1.x release. There's a definite appetite for the features that didn't make it into core already, but we can't predict whether or not that will be enough for them to be adopted into core even if developed. With an 8.x-1.x release those of us that need the features can start using them, regardless of the outcome of the core discussion.

So! What we need now is code :-)

We have a project now that desperately needed the "fixed menu parent" feature. We ended up writing a custom module and hardcoded the menu machine names into yml files.

Once we've recoded it to query the DB based off of a configuration screen, we'll post the Github repo here. Let me know if that might be helpful for anyone.

^ I could really use that biggm.

In the meantime, I'm using the patch at the link below which adds "Make the starting level follow the active menu item" functionality. Not ideal for a fixed parent solution, but it's working for those instances where you need to just follow the parent.

https://www.drupal.org/node/2631468#comment-10941953

Any status on the "Fixed Parent" selection from the original pre D8 Module? Thanks in advance.

I added the "fixed parent" option to https://github.com/robdecker/menu_block_ex

I just merged all the work in https://github.com/larowlan/menu_block into this project. I'm pretty sure most of that work got refactored and put into Drupal 8 core, but I'd like to recognize that work by merging it in here as well.

@rrrob I wasn't sure if your code was GPLv2. But I just compared menu_block_ex to SystemMenuBlock in core and it is clear that your code was forked off of Drupal 8 core, and, therefore, is also GPLv2. I tested your code and it works great! I'm going to merge it in too. Do you want to be a maintainer of Menu Block?

@JohnAlbin yeah I'll be a maintainer. Thanks

I removed any code for unimplemented features. We can revert this commit later and then finish those features. https://www.drupal.org/commitlog/commit/6358/03d6daf78884ff9d6eb3ea28262...

These features have not been ported:

• All of the old API hooks
• Ability to suppress menu blocks provided by System module.
• Ability to display "the menu selected by the page"
• Block title as link
• Administrative title
• Make the starting level follow the active menu item
• Sort menu tree by the active menu item’s trail

@rrob Welcome aboard! I gave you maintainer privileges last month, but forgot to mention it!