We need mappers for feeds import of vat fields.

CommentFileSizeAuthor
#4 commerce_vat-Issue-2141639-4.patch2.09 KBgeek-merlin

Comments

geek-merlin’s picture

Priority: Normal » Major
Issue summary: View changes

Feeds support deserves high prio imho.

Crosslinking #1940642: Tax reference field is not available for feeds module.

geek-merlin’s picture

anyone interested in or working on this?

geek-merlin’s picture

Status: Active » Needs review
StatusFileSize
new2.09 KB

Patch flying in. Worksforme.

lmeurs’s picture

@axel.rutz: Thanks a lot for your crosslinking and eventual patch, it's just what I was looking for. I tried your patch with Commerce EU VAT while importing a few demo products and it works great so far! Also did some successful tests with Feeds Tamper turning ie. 6% into the required machine name nl_reduced using their Find replace and Find replace REGEX plugins.

It's too early to set RTBC, so I linked to this patch from http://www.drupalcommerce.org/discussions/8675/commerce-feeds-and-commer... where people are looking for the same functionality.

My guess is that this patch should be part of Commerce Feeds since this module offers Feeds support for several other Commerce (related) modules. Should we move this discussion to #1254098: New target: VAT rate??

monterek’s picture

Hi Imeurs
Could you write how you've implemented this patch (#4) to the module commerce_eu_vat

lmeurs’s picture

@monterek: The patch was not witten for commerce_eu_vat, but for commerce_vat_reference, part of commerce_vat which is a dependency of commerce_eu_vat.

To be honest I patch manually, so I created the file commerce_vat_reference/commerce_vat_reference.feeds.inc inside the commerce_vat folder, pasted the patch's content in this file and stripped all patch code. Now when setting the field mapping for your processor you can select VAT as target (maybe flushing the caches is necessary). This automatically worked with Commerce EU VAT.

alex.cunha’s picture

Hi axel.rutz. Thanks. The patch worked for me perfectly using a sample CSV file. Using feeds tamper (the same recipe described by lmeurs). Soon will test importing +12000 products.

@monterek: See also how to apply patches

timlie’s picture

This works with commerce_eu_va.
Thanks!

ronino’s picture

Status: Needs review » Reviewed & tested by the community

Patch #4 works great. Thanks!

dwkitchen’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.