Updated: Comment #5

Problem/Motivation

The Node.js config module should be ported to Drupal 8.

Proposed resolution

See the attached patch. (Needs work)

Remaining tasks

1. Use $this->t instead of just t().

CommentFileSizeAuthor
#6 nodejs_config-drupal_8-2142007-6.patch21.8 KBid.medion
#6 interdiff-2142007-3-6.txt13.73 KBid.medion
#3 nodejs_config-drupal_8-2142007-3.patch20.48 KBid.medion
#3 interdiff.txt11.23 KBid.medion
nodejs_config_drupal_8.patch20.79 KBid.medion
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bohart’s picture

bohart
Location Lutsk, Ukraine
CreditAttribution: bohart commented
Status: Needs review » Needs work

Seems that we need to add here translation support.
So all text data should be wrapped with t() function.

id.medion’s picture

id.medion
Primary language Ukrainian
Location Lutsk
CreditAttribution: id.medion commented
Assigned: Unassigned » id.medion
id.medion’s picture

id.medion
Primary language Ukrainian
Location Lutsk
CreditAttribution: id.medion commented
Assigned: id.medion » Unassigned
Status: Needs work » Needs review
FileSize
interdiff.txt11.23 KB
nodejs_config-drupal_8-2142007-3.patch20.48 KB

Added support for translation and cleared trailing whitespace.

bohart’s picture

bohart
Location Lutsk, Ukraine
CreditAttribution: bohart commented
Status: Needs review » Needs work

Please look at FormBase::t.
Seems that we need to use $this->t instead of just t().

areke’s picture

areke CreditAttribution: areke commented
Issue summary: View changes
id.medion’s picture

id.medion
Primary language Ukrainian
Location Lutsk
CreditAttribution: id.medion commented
FileSize
interdiff-2142007-3-6.txt13.73 KB
nodejs_config-drupal_8-2142007-6.patch21.8 KB

@bohart, thanks for explain.
Also fixed other issues, please review.

id.medion’s picture

id.medion
Primary language Ukrainian
Location Lutsk
CreditAttribution: id.medion commented
Status: Needs work » Needs review
me-taras’s picture

me-taras CreditAttribution: me-taras commented

Commited, thanks!
http://drupalcode.org/project/nodejs.git/commit/9193180

me-taras’s picture

me-taras CreditAttribution: me-taras commented
Status: Needs review » Closed (fixed)

  • Commit 9193180 on 8.x-1.x, 8.x-1.x-head authored by medion, committed by v2nk: 
    Issue #2142007 by medion: Port Node.js Config module to Drupal 8