[D7] Entity reference autofill

Master Branch

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

You have a number of style issues reported here: http://pareview.sh/pareview/httpgitdrupalorgsandboxpoolfi2140197git, especially the non-unix line endings and form_state['values'] should be fixed. I did not review the full module.

----
Top Shelf Modules - Crafted, Curated, Contributed.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi jgullstr,

I have not even checked out your code yet to be honest, so maybe I am missing the point. Could you maybe describe a bit better, what exactly your module tries to achieve in the description?

You have dependency(entityreference_autofill.module:203) to entity module which doesn't stated anywhere. This should be stated in info file.

As soon as this is fixed it is good to me.

Jgullstr, thanks for that link.

I am sorry but I failed to understand what your module does, even my two fellow developers were clueless after reading the description.

What I did -
1. created a content type "abc"
2. created one more content type "xyz" and added two fields to it
a. abc_ref - entity reference to abc
b. a_fill - textfield
3. edited "abc" and added instance of a_fill to it.
4. edited "xyz" -> abc_ref , in autofill settings, i checked "Enable autofill for this field" , "Overwrite existing data" and "a_fill"

What next (if I am on correct path), it does nothing, I created few contents for abc and then few for xyz , but did not see any autofill.

Please guide me what to do next

Looks good to me after a manual review! Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to stBorchert as he might have time to take a final look at this.

Thanks for your contribution, Josef!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.