Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Anyone working on a version for Drupal 8 ?
If not i would like to do it. I am almost done with other module i maintain(customfilter) and now i know most of how work with filters in Drupal 8.
Comments
Comment #1
yukare CreditAttribution: yukare commentedCurrent working on it at github (https://github.com/yukare/geshifilter-d8).
It install and work, but still have a lot of bugs and missing things.
Comment #2
yukare CreditAttribution: yukare commentedI did some more work on it, still some missing parts, but it works, and pass the most of tests(only a few do not pass).
Please, can someone from maintainers review it?
Comment #3
soxofaan CreditAttribution: soxofaan commentedHi,
thanks for your work!
Unfortunately I don't have any D8 experience, so I won't be able to do a decent review.
On https://github.com/yukare/geshifilter-d8 I see that you just started over importing existing sources in a fresh git repo. I think it's better to start from the existing history (from http://git.drupal.org/project/geshifilter.git). That will make future review/cooperation/integration a lot easier.
Comment #4
yukare CreditAttribution: yukare commentedI can provide a patch to apply in the current 7.x-1.x and see the diff.
About the history, it will not matter that much, because the update from d7-d8 is a big change(much more than d6-d7) and almost all code now belong to new files in classes.
Can you give me write permission on a 8.x-1x branch here on drupal.org? I think that would be the best option, keep the code and history here. So i would import all work done to here in one commit, and work on each issue with one commit to preserve history.
Comment #5
soxofaan CreditAttribution: soxofaan commentedHi, created a new 8.x-1.x branch and added write permission for you
good luck :)
Comment #6
yukare CreditAttribution: yukare commentedCommited the current work: http://drupalcode.org/project/geshifilter.git/commit/39fb810
It is not complete, but it works. Some of the tests do not pass in local and most of it will not pass on drupal.org, because we can not have the GeShi library on testbot.
Comment #7
yukare CreditAttribution: yukare commentedNow that we are more close to a beta, i will resume work on this. Many changes are the same as i have to do on customfilter. Please, can you create a dev release for 8.x branch? So i can create issues against it.
Comment #9
yukare CreditAttribution: yukare commentedWith the last commit:
If someone know how to work with migrate, i need help in upgrade path.
Please try to use it and report anything you find, this is the best time to change anything.
Comment #10
yukare CreditAttribution: yukare commentedI found the cause of failing tests and module :(
Current only <> is working, the regular expression is not working for [], [[]], <?, maybe some change from php 5.2 to 5.4 or anything like this. I will work on the rest, most on css part and i plan to remove all the global functions to classes.
Comment #11
yukare CreditAttribution: yukare commentedWith last commit it is working with Drupal 8 beta 1. Please, consider creating a dev release or giving me permission to do it.
Comment #12
yukare CreditAttribution: yukare commentedNow i fixed most of it, all tests pass with just one exception, #1010216: Parser bug which reborn. I too fixed the filter tips(still need some work), all the part related to css.
Geshifield is working, but incomplete[#2353155].
I will work on #2353171: Clean up the code and make it oo., after this we will have almost everything done.
Comment #13
yukare CreditAttribution: yukare commentedThe current dev works on beta 2, just the same failing test as before.
The new submodule, geshifile, is working for me, just need some more work before a commit.
Comment #14
yukare CreditAttribution: yukare commentedComment #15
yukare CreditAttribution: yukare commentedSince we have a working version for drupal 8 with almost all features from drupal 7 working, and the ones that do not work have dedicated issues open for it, i will close this.
Please everyone test the last dev version to make geshifilter as stable as possible before a stable drupal release.