Needs review
Project:
Adaptive Image Styles (ais)
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
28 Nov 2013 at 18:41 UTC
Updated:
29 Nov 2013 at 16:20 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
mvcComment #2
mvcoops, forgot to properly handle the character set of the html snippet. fixed based on example from http://php.net/manual/en/domdocument.loadhtml.php
Comment #3
spotzero commentedThe function and hook implementations are incorrectly named. They should be named after the module to be correctly namespaced.
i.e.
ccdmd_filter_info() should be ais_filter_info()
_ccdmd_filter_adaptive_image_styles_process() should be _ais_filter_process().
_ccdmd_filter_adaptive_image_styles_tips() should be _ais_filter_tips().
Comment #4
mvcheh, oops. i was copying the code from a custom module written for a client :)