Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Updated: Comment 0
Problem/Motivation
There are a couple of local tasks left, of which #2032309: Use local tasks derivatives to provide local tasks for views fixes quite a couple of them.
Proposed resolution
Let's remove the rest of theme here and maybe even kill the actual code in menu.inc
Remaining tasks
User interface changes
API changes
Comment | File | Size | Author |
---|---|---|---|
#18 | interdiff.txt | 540 bytes | dawehner |
#18 | local_tasks-2147501.patch | 21.51 KB | dawehner |
#14 | local_tasks-2147501.patch | 21.62 KB | dawehner |
#14 | interdiff.txt | 1.67 KB | dawehner |
#13 | interdiff.txt | 3.31 KB | dawehner |
Comments
Comment #1
dawehnerHere is a patch now.
Comment #3
aspilicious CreditAttribution: aspilicious commentedDon't we need a parent_id in the SearchLocalTask local tasks?
Comment #4
dawehnerdoh!
Comment #5
dawehnerGood catch, thank you!
Comment #6
dawehnerForgot the interdiff.
Comment #9
dawehnerThis time this is green.
Comment #10
tim.plunkett#2032309: Use local tasks derivatives to provide local tasks for views would get this even closer.
Do we want to clear up MENU_SIBLING_LOCAL_TASK here too?
Comment #11
dawehnerWe cannot really here, as I used it in the patch for the admin/help page.
Comment #12
damiankloip CreditAttribution: damiankloip commentedThis should be TRUE instead of 1. The tag will get casted to a 1 when the tags are flattened, but this should be TRUE. It's just this particular tag storage that does this.
Comment #13
dawehnerFixed the review of damian.
Comment #14
dawehnerbla.
Comment #15
damiankloip CreditAttribution: damiankloip commentedGreat, thanks! That looks good now. Will RTBC when green.
note for others regarding #13, we can't do that because we still need to iterate through all cache bins to clear tags.
Comment #17
amateescu CreditAttribution: amateescu commentedThis looks duplicated.
Comment #18
dawehnerGood catch!
Comment #19
amateescu CreditAttribution: amateescu commentedLooks good now :)
Comment #20
webchickAwesome! Glad to see these picked off. From IRC, sounds like we're very close now outside of menu_test.module.
Although this...
Wow, that's quite a mouthful. :\ I guess that's what #2092529: [meta] Improve DX for defining custom routes is attempting to clean up?
In any event...
Committed and pushed to 8.x. Thanks!