Updated: Comment 0

Problem/Motivation

There are a couple of local tasks left, of which #2032309: Use local tasks derivatives to provide local tasks for views fixes quite a couple of them.

Proposed resolution

Let's remove the rest of theme here and maybe even kill the actual code in menu.inc

Remaining tasks

User interface changes

API changes

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

Status: Active » Needs review
FileSize
19.78 KB

Here is a patch now.

Status: Needs review » Needs work

The last submitted patch, 1: local_tasks-2147501.patch, failed testing.

aspilicious’s picture

Don't we need a parent_id in the SearchLocalTask local tasks?

dawehner’s picture

Status: Needs work » Needs review
FileSize
19.81 KB
787 bytes

doh!

dawehner’s picture

FileSize
20.01 KB

Good catch, thank you!

dawehner’s picture

FileSize
1005 bytes

Forgot the interdiff.

The last submitted patch, 4: local_tasks-2147501.patch, failed testing.

The last submitted patch, 5: local_tasks-2147501.patch, failed testing.

dawehner’s picture

FileSize
20.73 KB

This time this is green.

tim.plunkett’s picture

#2032309: Use local tasks derivatives to provide local tasks for views would get this even closer.

Do we want to clear up MENU_SIBLING_LOCAL_TASK here too?

dawehner’s picture

Do we want to clear up MENU_SIBLING_LOCAL_TASK here too?

We cannot really here, as I used it in the patch for the admin/help page.

damiankloip’s picture

+++ b/core/modules/search/lib/Drupal/search/Form/SearchSettingsForm.php
@@ -263,6 +263,7 @@ public function submitForm(array &$form, array &$form_state) {
+      \Drupal::cache('cache')->deleteTags(array('local_task' => 1));

This should be TRUE instead of 1. The tag will get casted to a 1 when the tags are flattened, but this should be TRUE. It's just this particular tag storage that does this.

dawehner’s picture

FileSize
23.27 KB
3.31 KB

Fixed the review of damian.

dawehner’s picture

FileSize
1.67 KB
21.62 KB

bla.

damiankloip’s picture

Great, thanks! That looks good now. Will RTBC when green.

note for others regarding #13, we can't do that because we still need to iterate through all cache bins to clear tags.

The last submitted patch, 13: local_task-2147501.patch, failed testing.

amateescu’s picture

+++ b/core/modules/entity/entity.local_tasks.yml
@@ -7,3 +7,18 @@ entity.form_mode_edit:
+entity.view_mode_list:
+  title: List
+  route_name: entity.view_mode_list
+  tab_root_id: entity.view_mode_list
+
+entity.view_mode_list:
+  title: List
+  route_name: entity.view_mode_list
+  tab_root_id: entity.view_mode_list

This looks duplicated.

dawehner’s picture

FileSize
21.51 KB
540 bytes

Good catch!

amateescu’s picture

Status: Needs review » Reviewed & tested by the community

Looks good now :)

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Awesome! Glad to see these picked off. From IRC, sounds like we're very close now outside of menu_test.module.

Although this...

+++ b/core/modules/search/lib/Drupal/search/Plugin/Derivative/SearchLocalTask.php
@@ -0,0 +1,42 @@
+/**
+ * Provides local tasks for each search plugin.
+ */
+class SearchLocalTask extends DerivativeBase {
+

Wow, that's quite a mouthful. :\ I guess that's what #2092529: [meta] Improve DX for defining custom routes is attempting to clean up?

In any event...

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.