Migrate D6 roles and permissions

Updating the issue to reflect that map has been renamed to static_map

I'm trying to sort out the "getting started" steps for writing migrations. Uploading my work-in-progress on the config file.

After much patient explaining from chx and some excellent new docs at https://drupal.org/node/2135345#scalar_list, here's a revised migration config file.

We still need tests and the two migration-specific plugins.

I'm not sure how the attachment got lost - here it is.

going to try some work on this.

here is an as-is first pass, still needing much work...

going to update the test to assert the mapped permissions...

this updates the asserts, including the mapped permissions from the permissions key in config. patch #12 is against HEAD from the imp sandbox. i wasn't quite sure how to re-roll this, amidst the imp sandbox to core issue queue transition.

1. +++ b/core/modules/migrate_drupal/lib/Drupal/migrate_drupal/Plugin/migrate/process/d6/NodeUpdate7008.php
   @@ -0,0 +1,34 @@
   +class NodeUpdate7008 extends ProcessPluginBase {
   
   +++ b/core/modules/migrate/lib/Drupal/migrate/Plugin/migrate/destination/Entity.php
   @@ -0,0 +1,88 @@
   +    $this->pluginManager = $plugin_manager;
   

   This variable name is not really helpful to understand what this plugin manager does. what about using migrateEntityField(Plugin)Manager ?
   As the documentation of __construct as well as properties are missing, I had to go all the way down to the container call to figure out what this could mean.

2. +++ b/core/modules/migrate/lib/Drupal/migrate/Plugin/migrate/destination/Entity.php
   @@ -0,0 +1,88 @@
   +    /*
   ...
   +    */
   

   If we don't really need it, let's try to not add it now?

1. +++ b/core/modules/migrate/lib/Drupal/migrate/Plugin/migrate/destination/Entity.php
   @@ -0,0 +1,88 @@
   +/**
   + * @PluginId("entity")
   + */
   
   +++ b/core/modules/migrate_drupal/tests/Drupal/migrate_drupal/Tests/source/d6/RoleSourceTest.php
   @@ -0,0 +1,145 @@
   + *
   + * @group migrate_drupal
   

   Again ... please add @group Drupal

2. +++ b/core/modules/migrate_drupal/tests/Drupal/migrate_drupal/Tests/source/d6/RoleSourceTest.php
   @@ -0,0 +1,145 @@
   +namespace Drupal\migrate_drupal\Tests\source\d6;
   ...
   +class TestRole extends Role {
   ...
   +use Drupal\Core\Database\Connection;
   +use Drupal\Core\Extension\ModuleHandlerInterface;
   +use Drupal\migrate_drupal\Plugin\migrate\source\d6\Role;
   

   I try to figure out why we need a seperate namespace here?

That's enough for the scope, another follow-up should be to add stub entities.
RTBC with small comment change

Committed c2e68a5 and pushed to 8.x. Thanks!

Cleaned up some very minor things during commit.

diff --git a/core/modules/migrate_drupal/lib/Drupal/migrate_drupal/Tests/d6/MigrateUserRoleTest.php b/core/modules/migrate_drupal/lib/Drupal/migrate_drupal/Tests/d6/MigrateUserRoleTest.php
index 3c6a38c..5c6526b 100644
--- a/core/modules/migrate_drupal/lib/Drupal/migrate_drupal/Tests/d6/MigrateUserRoleTest.php
+++ b/core/modules/migrate_drupal/lib/Drupal/migrate_drupal/Tests/d6/MigrateUserRoleTest.php
@@ -2,7 +2,7 @@
 
 /**
  * @file
- * Contains \Drupal\migrate\Tests\MigrateD6UserRoleTest.
+ * Contains \Drupal\migrate_drupal\Tests\d6\MigrateUserRoleTest.
  */
 
 namespace Drupal\migrate_drupal\Tests\d6;
@@ -37,11 +37,11 @@ function testUserRole() {
     $rid = 'migrate_test_role_1';
     $migrate_test_role_1 = entity_load('user_role', $rid);
     $this->assertEqual($migrate_test_role_1->id(), $rid);
-    $this->assertEqual($migrate_test_role_1->permissions, array(0 => 'migrate test role 1 test permission'));
+    $this->assertEqual($migrate_test_role_1->getPermissions(), array(0 => 'migrate test role 1 test permission'));
     $this->assertEqual(array($rid), $migration->getIdMap()->lookupDestinationID(array(3)));
     $rid = 'migrate_test_role_2';
     $migrate_test_role_2 = entity_load('user_role', $rid);
-    $this->assertEqual($migrate_test_role_2->permissions, array(
+    $this->assertEqual($migrate_test_role_2->getPermissions(), array(
       'migrate test role 2 test permission',
       'use PHP for settings',
       'administer contact forms',
diff --git a/core/modules/migrate_drupal/tests/Drupal/migrate_drupal/Tests/source/d6/RoleSourceTest.php b/core/modules/migrate_drupal/tests/Drupal/migrate_drupal/Tests/source/d6/RoleSourceTest.php
index 20b1ac0..0e0bf9a 100644
--- a/core/modules/migrate_drupal/tests/Drupal/migrate_drupal/Tests/source/d6/RoleSourceTest.php
+++ b/core/modules/migrate_drupal/tests/Drupal/migrate_drupal/Tests/source/d6/RoleSourceTest.php
@@ -2,10 +2,10 @@
 
 /**
  * @file
- * Contains \Drupal\migrate\Tests\source\d6\RoleSourceTest.
+ * Contains \Drupal\migrate_drupal\Tests\source\d6\RoleSourceTest.
  */
 
-namespace Drupal\migrate_drupal\Tests;
+namespace Drupal\migrate_drupal\Tests\source\d6;
 
 use Drupal\migrate\Tests\MigrateSqlSourceTestCase;
 
@@ -130,8 +130,6 @@ public function setUp() {
 
 }
 
-namespace Drupal\migrate_drupal\Tests\source\d6;
-
 use Drupal\Core\Database\Connection;
 use Drupal\Core\Extension\ModuleHandlerInterface;
 use Drupal\migrate_drupal\Plugin\migrate\source\d6\Role;