Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This issue is about introducing the actual requirement. For the policy discussion about whether or not to make Drupal core require PHP 5.4, see #1498574: [policy, no patch] Require PHP 5.4
Bump Drupal core's PHP requirement to 5.4.2 as per #1498574: [policy, no patch] Require PHP 5.4.
Comment | File | Size | Author |
---|---|---|---|
#18 | drupal8.php54.18.patch | 10.88 KB | dmouse |
#11 | drupal8.php54.11.patch | 10.55 KB | sun |
#1 | drupal_2152073_1.patch | 10.55 KB | Xano |
Comments
Comment #1
XanoThis patch was made by cosmicdreams and me back in #1498574: [policy, no patch] Require PHP 5.4.
Comment #2
klonosComment #3
webchickNote that I'm pretty sure this will continue to fail until we get 5.4.x testbots, which is blocked on #2135199: Provide php 5.4 testing on testbots for D8 code without breaking everything else. But at least now we can track it separately from various opinions on whether or not PHP 5.4 was a good idea. :) Thanks!
Comment #4
webchickThis isn't a feature; this is from a policy discussion that's already been decided.
Comment #6
webchickRight. That. Ok, then...
Comment #7
jessebeach CreditAttribution: jessebeach commentedComment #8
XanoThere may be an issue with testing traits. See #2159845: Upgrade to PHPUnit 4.
Comment #9
andypostMaybe 5.4.7?
Comment #10
sunAdding a critical issue.
Comment #11
sunComment #12
XanoIs there any difference between that patch and the one from #1?
Comment #14
sunSorry, nope, that was just a safety re-roll to facilitate PHP 5.4 testbot testing.
We're re-testing HEAD right now, so as to double-check whether the failures in #11 are real (which would mean that the switch to PHP 5.4 uncovered some real test failures in HEAD).
Comment #15
sunCreated #2205367: [HEAD BROKEN] PHP 5.4
Comment #16
Berdir11: drupal8.php54.11.patch queued for re-testing.
Comment #17
sunReviewed once more in depth, and all of the changes are awesomesauce.
To combat two potential questions/issues upfront:
Thanks!
Comment #18
dmouseWe also can add the version in composer.json
Comment #19
Dries CreditAttribution: Dries commentedI tried to commit this patch but it looks like
core/lib/Drupal/Core/Mail/PhpMail.php
was removed 8 hours ago. Looking at the patch, it seems like the PhpMail chunks can be removed safely, so I did exactly that. Committed to modified patch to 8.x. We may still have to delete death code from the new mailer class, if any.Comment #20
webchickOpened #2207021: Remove legacy PHP 5.3 code from PhpMail plugin as a follow-up.
Comment #21
XanoSee #2210257: Bump \Drupal\Component\Utility's PHP requirement to 5.4.2.
Comment #23
YesCT CreditAttribution: YesCT commentedrelated... #2246775: Suggest 5.4.11 as minimum PHP version for Windows and MacOS if XCache is enabled