Closed (fixed)
Project:
Views Load More
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Anonymous (not verified)
Created:
9 Dec 2013 at 13:10 UTC
Updated:
21 Nov 2024 at 22:36 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Maks commentedSame here
Comment #2
liquidgnome commentedi wound up commenting these lines out, as i'm not using a style plugin at all, and it appears as though the array key not being set is going to cause problems for fairly straightforward views_load_more usage until it's fixed.
just commenting the lines out seems to do the trick in lieu of actually checking to see if the ['type'] key is present for the time being.
Comment #3
marcoscanoJust checking for the 'type' key solved the problem for me
patch attached
Comment #4
marcoscanoComment #5
Maks commentedAfter applying the patch #3 problem disappeared.
Many thanks, marcoscano!
Comment #6
maximpodorov commentedObvious fix. Please commit.
Comment #7
subadmin commentedThanks #3 @marcoscano working fine :)
Comment #8
ptmkenny commentedClosed #2235949: Undefined index: type in views_load_more_views_ajax_data_alter() (row 52 as a duplicate, although there is a separate patch there
Comment #9
basvredelingI gave it some thought and I have to say I like the approach I proposed in #2235949: Undefined index: type in views_load_more_views_ajax_data_alter() (row 52 better. It doesn't just fix the error at hand, it allows for individual handling of different views display modes. This issue is only here because the display mode is not an HTML list. Instead of solving the symptom of the type index, we should single out lists completely and handle stuff like tables in a different manner. They might require an extra index themselves. Which would lead us to go back and refactor this tiny fix again...
Comment #10
m4oliveiI agree with basvredeling, and I needed to re-roll the patch against the latest 7.x-1.x release anyway, so here is a new patch.
What do you all think? Let me know and I shall commit it if it looks OK.
Thanks,
Matt
Comment #11
m4oliveiRe-roll against current 7.x-1.x
Comment #12
m4oliveiOn second thought, I'm just going to commit. Pretty safe patch here.
Patch #11 committed to 7.x-1.x-dev.
Thanks!
Comment #13
Anonymous (not verified) commented@m4olivei after updating to the latest dev am still getting the notice.
Comment #14
m4olivei@Dhamub looks like the packaged dev release is behind the 7.x-1.x branch ATM. Not sure on what schedule that updates. Can you try grabbing the 7.x-1.x branch from Git?