Problem/Motivation

On D7, this module only integrates with the core Overlay module (known to its poor performances) as Lightbox2 and Automodal have no stable releases yet. Colorbox is a growing module, based on the Colorbox library, already used by more than 150.000 sites over the world.

Proposed resolution

Integrates with Colorbox on the same basis than Lightbox2.

CommentFileSizeAuthor
#5 Colorbox Black Bar.png7.43 KBjay.lee.bio
#1 contact_importer-integrates_with_colorbox-2155967-1.patch1.69 KBduaelfr

Comments

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Assigned: duaelfr » Unassigned
Status: Active » Needs review
StatusFileSize
new contact_importer-integrates_with_colorbox-2155967-1.patch1.69 KB

Here is the patch.

This patch is part of the #1day1patch initiative.

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Status: Needs review » Fixed

Committed in dccf8a7.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jay.lee.bio’s picture

jay.lee.bio commented

After applying the patch, the Colorbox link does go to contact_importer_js?width=500&height=500&iframe=true, but it still goes to a new page. It does have a black bar towards the top of the page though. Any ideas?

P.S. If I apply the patch to 7.x-1.1, I'll get the following error in addition to still going to a new page with the black bar:

Notice: Undefined variable: options in contact_importer_js() (line 14 of /home/mysite/public_html/sites/all/modules/contact_importer/contact_importer.pages.inc).

jay.lee.bio’s picture

jay.lee.bio commented
Status: Closed (fixed) » Active
StatusFileSize
new Colorbox Black Bar.png7.43 KB
duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented

I think there is an option in Colorbox you may enable but I have nothing to watch out for it now.
I will provide a patch which enable this option automagically soon.

jay.lee.bio’s picture

jay.lee.bio commented

Thanks for the reminder. I forgot about it, which is called "Enable Colorbox load". Everything is ok now. Thank you!

P.S. Apparently the black bar is caused by CSS (when logged in as an admin), which can be easily overwritten.

jay.lee.bio’s picture

jay.lee.bio commented
Status: Active » Reviewed & tested by the community
duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Status: Reviewed & tested by the community » Fixed

I just added a description on the colorbox option to help the site builder to know he have to enable this option.
Pushed in 6ae9abe.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.