Closed (fixed)
Project:
Addressfield Autocomplete
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
13 Dec 2013 at 18:53 UTC
Updated:
16 Dec 2013 at 16:46 UTC
Jump to comment: Most recent
This is an interesting module I want to contribute myself.
There are some minor things to be fixed, which I'm sending a patch:
if ($widget['type'] == 'addressfield_standard') { because you have only 1 widget. Moreover, after the if you return $form, which may be undefined. I've fixed it removing the conditional.function addressfield_autocomplete_field_attach_submit() there is $items = field_get_items(...). This may lead to a bug at the next line - foreach - because field_get_items() may return FALSE. I've fixed it adding a conditional before the foreach().The attached patch can be applied using git apply patchname.patch. This will keep the correct author information.
| Comment | File | Size | Author |
|---|---|---|---|
| addressfield_autocomplete-coding_standards-2127007-24.patch | 6.23 KB | mac_weber |
Comments
Comment #1
adammitchell commentedHi Mac_Weber,
Many thanks for reviewing the module and providing the patch, this has been applied to the project. I have also updated the js file to be more in keeping with Drupal's coding standards.
Regards,
Adam