Closed (fixed)
Project:
IP Geolocation Views & Maps
Version:
7.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Reporter:
Created:
18 Dec 2013 at 16:58 UTC
Updated:
1 Apr 2015 at 01:41 UTC
Jump to comment: Most recent
Comments
Comment #1
rdeboerHi Mondrake,
Yes we need to sync up all three modules: Leaflet, Leaflet Markercluster and IPGV&M
Thanks for you report.
Rik
Comment #2
rdeboerPatch by mondrake applied and checked into 7.x-1.x branch with attribution.
Thanks mondrake.
IPGV&M 7.x-1.x-dev (out now, 7.x-1.24 when officially released) works with Leaflet 7.x-1.x-dev (out now, or 7.x-1.1 when officially released) and the latest Leaflet JS 0.7.1.
Also works with or without Leaflet More Maps 7.x-1.7.
Rik
Comment #3
arx-e commentedHi RiK,
Leaflet in views via IPGV&M is still not working for me http://test.ecoschools.gr/schools-map (display grey box with leaflet link and zoom +/-)
The same view configured as "Map (Google API, via IPGV&M)" is working fine with the same data: http://test.ecoschools.gr/
I am using all the latest dev versions:
IPGV&M 7.x-1.23+13-dev
Leaflet 7.x-1.0+5-dev
Leaflet More Maps 7.x-1.7+6-dev
Leaflet Markercluster 7.x-1.0-beta1
Get Locations 7.x-1.10
And I have tried both leaflet versions 0.6.4 and 0.7.1
Comment #4
rdeboerLeaflet MarkerCluster is not ready yet, I don't think, see #2144935: Broken with latest Leaflet Dev Version?.
So you need to temporarily drop Leaflet MarkerCluster from your mix of modules or revert Leaflet to 7.x-1.0-beta3 (7.x-1.0-beta3+44-dev) and possibly its alternative Leaflet JS libraries directory structure (with /dist in the path).
I see if I can find time to figure out what's going on and create a patch for Leaflet MarkerCluster, although it's not my module.
Comment #5
rdeboerI have checked in a number of changes to Leaflet MarkerCluster 7.x-1.x to make it compatible again after the changes made to Leaflet, in particular leaflet.drupal.js.
I've done some brief testing and found that the following combination of module versions seems to work when used together (and probably as a subset).
As of today, none of the versions below require patches
Leaflet 7.x-1.x-dev, using Leaflet JS 0.7.1
Leaflet More Maps 7.x-1.7 or 7.x-1x-dev
Leaflet MarkerCluster 7.x-1.x-dev, using Leaflet.markercluster JS version 0.4 (https://github.com/Leaflet/Leaflet.markercluster)
IP Geolocation Views and Maps 7.x-1.x-dev
Comment #6
arx-e commentedHi RiK, thanks a lot for your detailed response!
I updated to the latest dev versions and the map is showing now even with clustering enabled but the marker clusters are not showing:
http://test.ecoschools.gr/schools-map
IPGV&M 7.x-1.23+14-dev (Jan 05)
Leaflet 7.x-1.0+5-dev (Jan 03)
Leaflet More Maps 7.x-1.7+6-dev (Jan 01)
Leaflet Markercluster 7.x-1.0-beta1+5-dev (Jan 05)
leaflet.markercluster.js 0.4.0
Get Locations 7.x-1.10
Since it is a Markercluster issue I am copying this to the #2144935: Broken with latest Leaflet Dev Version?.
Comment #7
rdeboerWell that is bizarre as I just tried your link on my mobile on the tram to work and it works beautifully!
Ok, the cluster icons are square. That is because my phone browser, like old versions of IE, does not support rounded corners. But click on them and they explode like they should.
Have you done a HARD refresh, usually RIGHTCLICK Reload/Refresh ?
Rik
Comment #8
rdeboerI've just arrived at work and tried your site again, this time on my Macbook Pro.
This link, http://test.ecoschools.gr/schools-map, works perfectly on Safari and Firefox and Chrome with beautiful animated marker clusters that are circular on all three browsers.
Rik
Comment #9
arx-e commentedNow works for me too - after I emptied firefox's cache too.
Thanks!
Comment #10
todddd commentedAfter latest dev release of marker clusters, everything works well on my site again. Thanks to Rik
Comment #12
prezaeis commentedHi
Im having the exact same problem, i just get a div with nothing inside. I just upgraded all my modules to the latest dev version for the following (IP Geolocation Views, Leaflet, Leaflet More Maps and Leaflet Cluster)
I also have the latest libraries and no errors on the report page
What is going wrong ?
Comment #13
barwonhack commentedI too am experiencing this issue.
Strictly IOS ... I have tried a combination of themes and jQuery update configurations, as well as different versions of leaflet module and disabling related modules (cluster, ip_geoloc, etc).
Rik - would you please confirm that the issue exists for your good self?
Comment #14
rdeboerHi smilne23,
I cannot confirm this.
I am working on a presentation for DrupalSouth using these modules and all is fine.
Mind you, as I'm doing development on some of the modules involved as well, they're not identical to the official or even dev releases.
I would start with Leaflet by itself (with Views). Get that to work. Then enable additional modules one by one.
Rik
Comment #15
barwonhack commentedComment #16
barwonhack commentedHi Rik, Sorry read you comment after updating the issue ... will keep trying thanks.
Comment #17
barwonhack commentedFWIW: The issue only seemed to exist for User 1 when authenticated in IOS. I'm sure there's more to it ... but for now my best contribution to this thread thus-far is "test the defect under a different user account than U1".
Comment #18
rdeboer@smilne23:
Thanks for investigating and reporting back.
So can you confidently separate this issue from IPGV&M? If so, i.e. if this issue happens with only Views and Leaflet enabled, then we should move this issue to the Leaflet queue.
Rik
Comment #19
barwonhack commentedRick, I think it is a Leaflet issue.
FWIW: I have applied this (https://www.drupal.org/node/2185767#comment-8569559) patch to latest leaflet-dev . Without the patch Leaflet is somewhat unusable.
Comment #20
rdeboerFix on Leaflet side.