The views_plugin_display_block class is set to use exposed only if ajax is on, but this module doesn't need that. Let's remove the dependency!

CommentFileSizeAuthor
#13 remove_dependency_on-2162479-13.patch613 bytesyogeshmpawar
#8 vbfb-no_ajax_dependency-2162479-7.patch650 bytesdrclaw
#6 vbfb-no_ajax_dependency-2162479-6.patch598 bytespaulihuhtiniemi
#5 vbfb-no_ajax_dependency-2162479-5.patch619 bytesdrclaw
#3 vbfb-no_ajax_dependency-2162479-3.patch611 bytesdrclaw
#1 vbfb-no_ajax_dependency-2162479-1.patch452 bytesdrclaw

Comments

drclaw’s picture

drclaw commented
Issue summary: View changes
StatusFileSize
new vbfb-no_ajax_dependency-2162479-1.patch452 bytes

Attached patch removes ths ajax dependency.

drclaw’s picture

drclaw commented
Status: Active » Needs review

Needs review :)

drclaw’s picture

drclaw commented
StatusFileSize
new vbfb-no_ajax_dependency-2162479-3.patch611 bytes

Last patch actually exposes the form on all blocks. Oops! Here's one that only exposes it for blocks with AJAX on, or if the exposed form is exposed as a block.

iamEAP’s picture

iamEAP commented

Thanks for the patch @drclaw! Tested this on simplytest.me and works as promised. I'll do a code review soon...

drclaw’s picture

drclaw commented
StatusFileSize
new vbfb-no_ajax_dependency-2162479-5.patch619 bytes

Hi, thanks for testing it out! While we're on the subject, here's an updated one with a slightly less error prone check for the exposed form setting (I noticed a bunch of "undefined index" errors in my logs recently).

Thanks!

paulihuhtiniemi’s picture

paulihuhtiniemi commented
StatusFileSize
new vbfb-no_ajax_dependency-2162479-6.patch598 bytes

Maybe I'm missing something, but shouldn't it be only for Views that have filters exposed as blocks?

bart vanhoutte’s picture

bart vanhoutte commented
Status: Needs review » Reviewed & tested by the community

Tested #6, looks good.

drclaw’s picture

drclaw commented
StatusFileSize
new vbfb-no_ajax_dependency-2162479-7.patch650 bytes

@paulihuhtiniem I think we need to keep the use_ajax() check in there. This module actually replaces the the original views block plugin so we need to keep the original functionality intact in addition to our exposed as block check. If not, the filters won't appear on view blocks that have exposed filters that aren't exposed as a block.

And now that I think about it, I think we should probably call the views_plugin_display class's uses_exposed() method instead of just returning TRUE since not all blocks with AJAX turned on will have exposed filters (in the case of only having a pager for example). Patch attached!

drclaw’s picture

drclaw commented
Status: Reviewed & tested by the community » Needs review
bart vanhoutte’s picture

bart vanhoutte commented
Status: Needs review » Reviewed & tested by the community

#8 is right, tested and works.

  • iamEAP committed 227d627 on 7.x-1.x authored by drclaw 
    Issue #2162479 by drclaw, paulihuhtiniemi: Remove dependency on block...
iamEAP’s picture

iamEAP commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Thanks everyone! Tried it out myself on simplytest.me and it works as expected.

Moving to 8.x so that it gets applied.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
StatusFileSize
new remove_dependency_on-2162479-13.patch613 bytes

Here's the patch for 8.x-1.x branch.

  • Yogesh Pawar committed 06b0844 on 8.x-1.x 
    Issue #2162479 by drclaw, paulihuhtiniemi, Yogesh Pawar: Remove...
yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Status: Patch (to be ported) » Fixed

Committed & pushed to 8.x-1.x branch also assigning credits.

arosboro’s picture

arosboro commented
Status: Fixed » Needs work

The patch in #13, applied with 06b08442edc4, had me scratching my head. It doesn't include a ! (NOT) operator, so all views without AJAX enabled break.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Status: Needs work » Fixed

@arosboro - Marking this issue as Fixed because this issue is solved Empty exposed forms appeared issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.