Ubercart does not provide RTL support. all css styles are ltr only.
Please add right-to-left support in stylesheets.

CommentFileSizeAuthor
#32 2162483-32-rtl.patch16 KBtr
#31 2162483-31-rtl.patch16 KBtr
#15 uc_cart_block-after (firefox bug).png5.43 KBherom
#15 uc_cart_block-before.png5.5 KBherom
#15 interdiff-11-15.txt310 bytesherom
#15 ubercart-rtl_support-2162483-15.patch18.24 KBherom
#14 4.jpeg62.73 KBhadi farnoud
#14 3.jpeg120.46 KBhadi farnoud
#14 2.jpeg48.63 KBhadi farnoud
#14 1.jpeg65.69 KBhadi farnoud
#11 interdiff-4-ltr.txt11.16 KBherom
#11 interdiff-4-css.txt1.39 KBherom
#11 ubercart-rtl_support-2162483-11.patch18.22 KBherom
#4 ubercart-rtl_support-2162483-4.patch7.14 KBhejazee

Comments

tr’s picture

tr commented

Can you provide specific details about what needs to be fixed? Or perhaps a patch?

Much of our markup is styled by core Drupal, but we will certainly change any Ubercart-specific CSS that doesn't support RTL. We just don't know what that is right now ...

hejazee’s picture

hejazee commented

Yes, I'm working on it and I will solve the problem. but I may need some help by others.
None of the css files have a matching rtl file.
for example uc_cart.css is there, but uc_cart-rtl.css is missing.
In the UI, rtl does not work correctly.
I'm creating rtl css files and I'll create a patch for this.

hejazee’s picture

hejazee commented
Assigned: Unassigned » hejazee
hejazee’s picture

hejazee commented
StatusFileSize
new ubercart-rtl_support-2162483-4.patch7.14 KB

Please test this patch.

tr’s picture

tr commented
Version: 7.x-3.6 » 7.x-3.x-dev
Status: Active » Needs review

Let the testbot look first.

hejazee’s picture

hejazee commented

Does the test bot, test css files?
as far as i know, css files can not be tested with drupal's testing framework!

hadi farnoud’s picture

hadi farnoud commented

it's not clear what the issue is with current rtl css files.

please explain the problem and the areas you have fixed. otherwise, don't expect someone test all ubercart for you

hejazee’s picture

hejazee commented

If you look at my patch, you can see that I have created all -rtl files.
They are:

  • payment/uc_payment/uc_payment-rtl.css
  • shipping/uc_quote/uc_quote-rtl.css
  • uc_cart/uc_cart_block-rtl.css
  • uc_cart/uc_cart-rtl.css
  • uc_order/uc_order-rtl.css
  • uc_product/uc_product-rtl.css
  • uc_product_kit/uc_product_kit-rtl.css
  • uc_store/uc_store-rtl.css

Most important items include:

  • the checkout progress
  • cart block
  • shopping cart
  • payment page
tr’s picture

tr commented

Hejazee: Can you please add /* LTR */ comments into the main .css files for the styles you're overriding? This is part of the Drupal coding standards explained at Supporting "right to left" (RTL) languages. These comments will identify the styles that are direction specific, so if we ever change them in the future (likely!) we will know to make the same changes in the RTL files.

I don't see anything wrong with your .css files, but I don't have a good way to test them myself.

For CSS changes, the test bot is used only to make sure the patch applies and doesn't contain any syntax errors.

hadi farnoud’s picture

hadi farnoud commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

There are no Ubercart Persian translation Hejazee.

I did test your patch in English language (Persian lang selected though). it looks fine to me although it would've been better to test it in Persian.

herom’s picture

herom commented
Status: Reviewed & tested by the community » Needs review
Issue tags: +Needs screenshots
StatusFileSize
new ubercart-rtl_support-2162483-11.patch18.22 KB
new interdiff-4-css.txt1.39 KB
new interdiff-4-ltr.txt11.16 KB

removed some unnecessary -rtl.css code. also, added /* LTR */ comments mentioned in #9. (separate interdiffs added for easier review).

some before/after screenshots would be very helpful here, too (that unfortunately I could not make, due to some config issues with ubercart).

hadi farnoud’s picture

hadi farnoud commented

Hejazee, please upload the translation as well. Or just review and accept them on localisation server.

hejazee’s picture

hejazee commented

I think there is a problem with localize.drupal.org
because translations of new releases of modules and drupal core are not available.
you can download translations from this page:
https://localize.drupal.org/translate/languages/fa/export

select the latest release which is available in the list.

hadi farnoud’s picture

hadi farnoud commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 1.jpeg65.69 KB
new 2.jpeg48.63 KB
new 3.jpeg120.46 KB
new 4.jpeg62.73 KB

looks fine to me

herom’s picture

herom commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new ubercart-rtl_support-2162483-15.patch18.24 KB
new interdiff-11-15.txt310 bytes
new uc_cart_block-before.png5.5 KB
new uc_cart_block-after (firefox bug).png5.43 KB

added a padding fix for uc_cart_block links.

there is still an issue with the "cart-block-arrow" in uc_cart_block, that appears only in firefox. I have added screenshots for that.

herom’s picture

herom commented
Status: Needs work » Needs review

umm... let's get the testbot on the patch. then I'll change back to "needs work".

herom’s picture

herom commented
Status: Needs review » Needs work
hadi farnoud’s picture

hadi farnoud commented

@herom:

testbot does not validate css syntax. it just check that your patch applies.

for easier review, you can use simplytest.me. in advanced, you can add ubercart and apply the patch.

hadi farnoud’s picture

hadi farnoud commented
Status: Needs work » Needs review
tr’s picture

tr commented
Status: Needs review » Needs work

The reason it's in "Needs work" is because of #15: "there is still an issue with the "cart-block-arrow" in uc_cart_block, that appears only in firefox." If we get a new patch with that item fixed then it can be reviewed again.

W.M.’s picture

W.M. commented

There seems not -rtl files inside Ubercart module folders. I hope that the above listed patches get embedded in next stable releases.

tr’s picture

tr commented
Issue tags: -Needs screenshots

@W.M.: Please test the patch in #15 and please help correct the problem with "cart-block-arrow". The fix can only be made if people like you who use RTL get involved.

hejazee’s picture

hejazee commented
Issue summary: View changes

Reset issue summary. (it had been removed)

hejazee’s picture

hejazee commented
Status: Needs work » Needs review

#15: I don't see this bug in current version of firefox (version 42)
I will review this patch again and update the issue afterwards.

tr’s picture

tr commented

@hejazee: If you can verify the patch still works I'd like to commit the patch now. It's certainly better than what we have, and if any issues show up because of it we can fix them later.

hejazee’s picture

hejazee commented
Status: Needs review » Patch (to be ported)

I have tested the latest patch in a few sites.
Looks good. I don't see any problem.

hejazee’s picture

hejazee commented
tr’s picture

tr commented
Version: 7.x-3.x-dev » 8.x-4.x-dev

Thank you for all the hard work to make this happen! I'm glad this is finally done.

Patch from #15 was committed to 7.x-3.x, leaving this open to be ported to 8.x-4.x.

If any problems arise with the RTL css from this patch, please open a new follow-up issue.

  • TR committed 4f51f6c on 7.x-3.x authored by hejazee 
    Issue #2162483 by herom, hejazee: RTL support
hejazee’s picture

hejazee commented
Status: Patch (to be ported) » Needs work

Thank you @TR.
Set status to "Needs work"

tr’s picture

tr commented
Status: Needs work » Needs review
StatusFileSize
new 2162483-31-rtl.patch16 KB

Here's a port to D8. I used the D7 patch as a guideline.

NOT TESTED!

tr’s picture

tr commented
Status: Needs review » Fixed
StatusFileSize
new 2162483-32-rtl.patch16 KB

Made two minor changes, patch attached. I am just going to commit this without review because I want to lock in the RTL goodness before 8.x-4.x CSS diverges too much more from the 7.x-3.x stuff. If a problem arises with RTL support in D8 we can correct it in a separate issue.

  • TR committed ca75d25 on 8.x-4.x 
    Issue #2162483 by TR, herom, hejazee: RTL support for D8

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.