Split up contextual.toolbar.js

I haven't done the renaming part yet.
contextual.toolbar.js has a model attribute

  var contextualToolbar = Drupal.contextualToolbar;
  var model = contextualToolbar.model = new contextualToolbar.Model();

and we are also doing
if (Drupal.contextual && Drupal.contextual.collection) {
So I don't think that we can move Drupal.contextualToolbar.model to Drupal.contextual.ToolbarModel because if we want to move Drupal.contextualToolbar.VisualView to Drupal.contextual.ToolbarVisualView then we have to change

/**
 * Model and View definitions.
 */
Drupal.contextualToolbar = {
  // The Drupal.contextualToolbar.Model instance.
  model: null
};

to

/**
 * Model and View definitions.
 */
Drupal.contextualToolbar = {
  // The Drupal.contextual.ToolbarModel instance.
  toolbarModel: null
};

which is not right.

Forgot to add a file.

4: d8.split-contextual.toolbar.js_.2162837-4.patch queued for re-testing.

Reroll

This patch conflicts with #2162409: Split up contextual.js. Let's get that one in first.

That one's in, this will need a re-roll.

We can't split it as it is. First we have to change the Model and Views name because we already have AuralView.js for Drupal.contextual.AuralView so we have to rename the Drupal.contextualToolbar.AuralView.

Yep. Here's a patch that does all that.

Nice approach. And thanks for Hijeacking my patch :P :D. I'll let @nod_ RTBC it.

Sorry! I really needed needed a break from the huge patches I've been working on. Glad you like it!

The patch still applies.

I manually tested and found no regressions. This patch just pushes some code around into separate files; it does not alter the existing behavior.

Looks good to go.

Testbot is broken ATM, see #2248217: Update Drush to newer SHA1.

14: split_contextual_toolbar_js-2162837-14.patch queued for re-testing.

Back to RTBC as per #17.

14: split_contextual_toolbar_js-2162837-14.patch queued for re-testing.

Green again, back to RTBC again, again as per #17.

Committed and pushed to 8.x. Thanks!