After updating to version 7.x-2.11, I found that the slider on the homepage no longer animated and was stuck on the first slide. I also noticed that there was a visual gap between my the bottom of my administrative menu and the page leading me to believe it was a Javascript error.

NOTE: This problem may have originated in the 7.x-2.10 update as I did notice the issue when I updated to that version but I thought it had gone back to normal when I cleared the cache. With the 7.x-2.11 update I again saw the issue but after clearing the cache it reappeared after reloading the homepage.

I tracked it down to what looks like a simple syntax error in: commerce_kickstart/modules/commerce_kickstart/commerce_kickstart_slideshow/commerce_kickstart_slideshow.js on line 10. I've repaired it on the site in question and I'll attach a patch in a moment.

The site is a Drupal 7.24 site with Commerce Kickstart 7.x-2.11 which has been updated several times from 7.x-2.6 and uses a customized Omega Kickstart theme.

Edit: Someone had a similar problem as noted on the Drupal Commerce site: http://www.drupalcommerce.org/discussions/12511/modification-here-bug-ki...

Edit: Closed as duplicate of: HP Slideshow has stopped after update CK to 2.10 version. I've moved the patch to that thread.

Comments

awasson’s picture

awasson’s picture

Issue summary: View changes
makokis’s picture

#1
Posted by awasson

thanks, this patch works for me. Solved.

awasson’s picture

Oh, I just noticed that this is a duplicate of: HP Slideshow has stopped after update CK to 2.10 version. I've uploaded the patch to that thread and am closing this as duplicate.

awasson’s picture

Status: Active » Closed (duplicate)
awasson’s picture

Issue summary: View changes
lawless’s picture

I don't understand what this means:
diff --git a/modules/commerce_kickstart/commerce_kickstart_slideshow/commerce_kickstart_slideshow.js b/modules/commerce_kickstart/commerce_kickstart_slideshow/commerce_kickstart_slideshow.js
index ab53b03..aa104a5 100644
--- a/modules/commerce_kickstart/commerce_kickstart_slideshow/commerce_kickstart_slideshow.js
+++ b/modules/commerce_kickstart/commerce_kickstart_slideshow/commerce_kickstart_slideshow.js
@@ -7,7 +7,8 @@

The only difference I see is line 10 change from:
var slider = $('.event-slider', context).bxSlider({

to:
var slider = $('.event-slider', context);
slider.bxSlider({

Is that right or am I missing something?

awasson’s picture

Yup, you got it.

It's a Git patch. All the other stuff is so that the patch utility can find the right file and make the fix at the right spot. Basically so that the maintainers of Commerce Kickstart can test it and apply it quickly without breaking anything.

lawless’s picture

Oh cool, I get it now, thank you.

awasson’s picture

No worries, glad to help.