I made the following improvements for a project I've worked on so here they are:
- Fixes:
- Code cleanup to meet Drupal coding standards (mostly indentation).
- Converted width and height elements to varchar so other units than pixels can be specified. Defaults to pixels through HTML attributes.
- Allowed default values to be set for all field elements even when the ID is empty.
- Escaped all iframe URL parameters and attributes through check_plain to avoid code injection.
- Fixes on field names and descriptions to make everything more clear.
- Improvements:
- Automatic i18n support (as supported by the Wikiloc site). Fallback to English for Wikiloc unsupported languages.
- Added validation to check that ID element is numeric.
- Moved module into Fields package.
You have to run update.php after applying the patch.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | wikiloc-cleanup-and-fixes-2166219-0.patch | 11.42 KB | gonssal |
Comments
Comment #1
gonssalComment #2
gonssalComment #3
jmaties commentedNot received notifications!!! :(
Sorry and thanks
Comment #4
jmaties commentedPatched