Navbar has a 1.1 release and Core is up to 7.25.

CommentFileSizeAuthor
#5 configure-modernizr-library-2166821-5.patch2.24 KBdevin carlson
#3 configure-modernizr-library-2166821-3.patch2.3 KBdevin carlson

Comments

ezra-g’s picture

ezra-g commented
Assigned: Unassigned » ezra-g
ezra-g’s picture

ezra-g commented
Status: Active » Fixed

Ahem, Navbar is up to 1.2.

Both are now updated: http://drupalcode.org/project/commons.git/commitdiff/25d4296?hp=ab450a2f....

devin carlson’s picture

devin carlson commented
Status: Fixed » Needs review
StatusFileSize
new configure-modernizr-library-2166821-3.patch2.3 KB

Unfortunately, we can't include a preconfigured, minified version of Modernizr from modernizr.com so we'll have to tell navbar to use the source variant of the Modernizr library. The navbar update didn't include a configuration for the library variants so this resulted in the Modernizr library not being loaded and the navbar not working properly.

The attached patch adds navbar_libraries_variants to the list of strongarm variables featurized by Commons Miscellaneous Configuration and includes an update function to revert the variables configuration. This could also be done in commons.install if anyone thinks that it isn't worth featurizing.

ezra-g’s picture

ezra-g commented
Assigned: ezra-g » Unassigned
Status: Needs review » Reviewed & tested by the community

Thanks for catching and patching that! Exporting this as a variable seems like a fine approach. Marking as RTBC.

devin carlson’s picture

devin carlson commented
StatusFileSize
new configure-modernizr-library-2166821-5.patch2.24 KB

A reroll of #3.

devin carlson’s picture

devin carlson commented
Status: Reviewed & tested by the community » Fixed

Tested #5 with a fresh and an existing Commons site and confirmed that the Modernizr library loads correctly and Navbar functions properly.

Committed #5 to Commons 7.x-3.x.

http://drupalcode.org/project/commons.git/commit/5b34ecb

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.