Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Navbar has a 1.1 release and Core is up to 7.25.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | configure-modernizr-library-2166821-5.patch | 2.24 KB | devin carlson |
| #3 | configure-modernizr-library-2166821-3.patch | 2.3 KB | devin carlson |
Comments
Comment #1
ezra-g commentedComment #2
ezra-g commentedAhem, Navbar is up to 1.2.
Both are now updated: http://drupalcode.org/project/commons.git/commitdiff/25d4296?hp=ab450a2f....
Comment #3
devin carlson commentedUnfortunately, we can't include a preconfigured, minified version of Modernizr from modernizr.com so we'll have to tell navbar to use the source variant of the Modernizr library. The navbar update didn't include a configuration for the library variants so this resulted in the Modernizr library not being loaded and the navbar not working properly.
The attached patch adds
navbar_libraries_variantsto the list of strongarm variables featurized by Commons Miscellaneous Configuration and includes an update function to revert the variables configuration. This could also be done in commons.install if anyone thinks that it isn't worth featurizing.Comment #4
ezra-g commentedThanks for catching and patching that! Exporting this as a variable seems like a fine approach. Marking as RTBC.
Comment #5
devin carlson commentedA reroll of #3.
Comment #6
devin carlson commentedTested #5 with a fresh and an existing Commons site and confirmed that the Modernizr library loads correctly and Navbar functions properly.
Committed #5 to Commons 7.x-3.x.
http://drupalcode.org/project/commons.git/commit/5b34ecb