Remove uses of deprecated language functions in tests and procedural code

function language_list($flags = Language::STATE_CONFIGURABLE) {
  return \Drupal::languageManager()->getLanguages($flags);
}
function language_load($langcode) {
  return \Drupal::languageManager()->getLanguage($langcode);
}
function language_default() {
  return \Drupal::languageManager()->getDefaultLanguage();
}

Wowza, this is a much larger effort than I imagined.

Attached patch is just language_list(), and it does not properly injected the language_manager service dependency yet.

Perhaps we should split this issue into three discrete issue for the 3 functions?

OK, I started this issue to remove the language_load function before I found this issue:

#2182133: language_load() is deprecated, replace with provided suggestion.

I will focus on removing the language_load function in favor of it's corresponding method from the language manager.

Good to hear. So let's create the last missing separate issue for language_default().

To be honest, I did not actually expect this patch here to pass tests... While that is great, we still need to properly inject the language manager where possible.

Yea, it does feel a bit excessive to always be calling the language manager from the global drupal object. I ended up starting an issue for language() as well: #2182257: language() is deprecated, replace with suggested function

Both of the issues I started for this are copy-paste jobs (that I went through change by change to make sure it was done with oversight.

Re-roll, also keeps the language_list function itself to reduce the chance of the patch breaking HEAD.

While injecting the language manager is the preferred option, do we need to do it in this patch, which is already 50k? I think we're better replacing all the procedural functions first on a per-function basis, then going through the OO code adding DI on a per-module basis (i.e. replacing all calls to \Drupal::languageManager(), whatever function was eventually being called).

11: 2166915-remove-uses-language-list-11.patch queued for re-testing.

On second thoughts, this isn't a great candidate for the script

This patch is just a combination / reroll of #11, plus #2182133-1: language_load() is deprecated, replace with provided suggestion. by cosmicdreams.

If we're going to split this up, it would make more sense to do so by file rather than function, as otherwise the sub-issues will conflict with each other, especially when we start doing dependency injection. I'm working on a combined patch, but might split it that way if it gets too large.

OK, I've reduced the scope of this issue to cover just tests and procedural code - i.e. places where we don't need to worry about dependency injection. I'll open a separate issue for the OO code.

No interdiff I'm afraid, but I don't think it would have helped much if I had been able to provide one.

I've changed that comment to:

  // Update URL Prefixes for all languages after the new default language is
  // propagated and the LanguageManagerInterface::getLanguages() cache is
  // flushed.

No other changes.

Thanks for the review. We don't want to cause unnecessary rerolls of more important patches during drupaldevdays, so postponing for now and I'll reroll this over the weekend if it needs it.

Actually, this didn't conflict much at all - just two context changes in one test.

Committed and pushed to 8.x. Thanks!