Tiny little patch, stripe is now in Australia, this patch works fine (stripe api is so damn nice!)

CommentFileSizeAuthor
add_aud.patch502 byteser_d0s

Comments

iler’s picture

iler commented
Status: Patch (to be ported) » Fixed

This is now fixed in RC6.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

bensey’s picture

bensey commented
Status: Closed (fixed) » Needs review

Hi there,

I've just installed RC6 and then dev on a current project and set its default for AUD, but the status report page still reports:

Stripe currency check - Invalid default currency!
Stripe currently supports only USD, CAD, EUR, GBP and CHF as a currency.

Is this going to cause an issue processing with AUD? Stripe is on Beta in Australia, and I'm using it in other capacities, but this is the first time I'm planning to use it in a Drupal project...

Thanks, Ben.

aviindub’s picture

aviindub commented

the patch in OP was incomplete, it needed to include AUD in the verification code in commerce_stripe.install as well. I have committed a fix to dev, please let me know if this fixes the issue for you. Here's the commit: fix AUD

bensey’s picture

bensey commented

Hi aviindub,

yep this seems to fix the Invalid AUD currency message on the status report for me here.

Thanks!

aviindub’s picture

aviindub commented
Status: Needs review » Closed (fixed)
carrotandme’s picture

carrotandme commented

Now, Stripe supports JPY. So, all I have to do is something like below?

-    if (in_array(commerce_default_currency(), array('USD', 'CAD', 'EUR', 'GBP', 'AUD', 'CHF')))
+    if (in_array(commerce_default_currency(), array('USD', 'CAD', 'EUR', 'GBP', 'AUD', 'CHF','JPY'))) 

-        'description' => $t('Stripe currently supports only USD, CAD, EUR, GBP, AUD and CHF as a currency.'),
+        'description' => $t('Stripe currently supports only USD, CAD, EUR, GBP, AUD, JPY and CHF as a currency.'),

right?

torgospizza’s picture

torgospizza
he/him
Primary language English
Location Portland, OR
commented

@carrotandme: You're replying to a Closed issue, which is not the ideal place to ask this question.

In fact the currency implementations for Stripe have changed a lot since 1.x - mainly, the list of currencies Stripe supports, depends on the country of origin of the Stripe account. I have a patch for this pending, and hope to roll it out soon. If you'd like, create a new Issue in the queue for this feature (assign it to 3.x version of this module) and I will post my updates there.

carrotandme’s picture

carrotandme commented

@torgosPizza
Thank you for your reply. I created the new issue for that.
https://www.drupal.org/node/2885093