Wrong value used in APC shim size install error [#2167929]

Nitpicking really, but on install if APC shim size is insufficient, error message says:

"APC is installed but 96M is not enough APC cache to successfully install Drupal Commons. Find you APC.ini file and change the apc.shm_size value to at least 96M."

rather than:

"APC is installed but 32M is not enough APC cache to successfully install Drupal Commons. Find you APC.ini file and change the apc.shm_size value to at least 96M."

Spot the difference.

Noticed as part of #2167921: APC shim size insufficent to install Drupal Commons

Comments

Comment #1

lightsurge commented 6 January 2014 at 12:50

$requirements['apc_shm_size']['description'] = $t('APC is installed but %shm_size is not enough APC cache to successfully install Drupal Commons.
           Find your <em>apc.ini</em> file and change the <em>apc.shm_size</em> value to at least <em>96M</em>.', array('%shm_size' => COMMONS_MINIMUM_APC_CACHE . 'M'));

Should be:

$requirements['apc_shm_size']['description'] = $t('APC is installed but %shm_size is not enough APC cache to successfully install Drupal Commons.
           Find your <em>apc.ini</em> file and change the <em>apc.shm_size</em> value to at least <em>%min_shim_size</em>.', array('%shim_size' => $shim_size . 'M', '%min_shm_size' => COMMONS_MINIMUM_APC_CACHE . 'M'));

Although I don't really understand why we want to use a constant for minimum apc cache size? Or why we need to mess about cutting the M off the current shim size and then adding it back on?

http://drupalcode.org/project/commons.git/blob/refs/heads/7.x-3.x:/commo...