[D7] Image Styles Formatter

Hello,

Here are some quick issues to get started:

- The git clone is your personal git URL. This is your public Git clone command:
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/ngocketit/2154645.git
- You should delete your master branch, according to https://drupal.org/empty-git-master
- Take a look at the automated code review results here:
http://pareview.sh/pareview/httpgitdrupalorgsandboxngocketit2154645git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi ngocketit, here are my observations on your project:

The image_styles_formatter.info and image_styles_formatter.module files have the execution bit set (755 instead of 644).

I suppose you could add comment to document the arguments of the functions _image_styles_formatter_sort_image_styles(), _image_styles_formatter_get_image_info(), _image_styles_formatter_output_list().

Hi,

I took a look at the code and perhaps the following could be improved:

• Make sure the text lines in the info file are no longer than 80 chars.
• Add @param and @return info to your custom function documentation. Perhaps you could be a little bit more generous with comments, overall.
• On line 366 you're adding tokens. A common way to add a token list to a form is using the token_tree form element.
• The description phrases on line 382 and 398 are missing a period at the end. Details though. :-)

Good luck!

Lennart

Hi ngocketit, as my first review, I installed & tested the module, also had a brief look at the code. I think the code looks good, at least clean and standard. This small module may be helpful to somebody who wants to have the same image field to be displayed in several image styles at the same time.

@ngocketit: Are you the same person as @drush7?

• @drush7 created an account in February and immediately posted a review of this project, changing the status to RTBC.
• @drush7 has made no other posts at all on drupal.org.
• Now today @drush7 has bumped this issue to the top of the queue.

It sure looks like you created a second account on drupal.org just to push your application along.

Meanwhile, you haven't made any commits to this project since January, and specifically all the Pareview errors that were pointed out in January are still there. See http://pareview.sh/pareview/httpgitdrupalorgsandboxngocketit2154645git

Yes, the review process can be slow, but as long as you respond to the reviewers remarks and make the suggested changes your application *will* be approved. The only way to get it denied is to fail to participate. The documentation on the review process gives you suggestions on how to get through this faster - getting a review bonus (see above) is one way. When I see deceptive practices, however, I personally put my efforts towards looking at other projects.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.