Into the following string (l.d.o ID #1790263):

Removed "teaser" column. All forms that had the "Show complete form in teaser" option disabled will now show forms in their teasers. Use view modes to hide the form if desired.

needs to insert the highlighted word, because this is the description of that option which it refers to (l.d.o ID #230122). Without the missing "complete" word can be confusing what is trimmed for teaser and what is displayed entirely.

CommentFileSizeAuthor
#4 2171485-webform-inserting-a-missing-word.patch765 bytesBalu Ertl
#3 2171485-webform-inserting-a-missing-word.patch0 bytesBalu Ertl
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Balu Ertl’s picture

Balu Ertl
he/him
Primary language Hungarian
Location Budapest 🇪🇺
CreditAttribution: Balu Ertl commented
Title: Inserting a missing word into a string » [Patch] Inserting a missing word into a string
Version: 7.x-4.0-beta1 » 8.x-4.x-dev
Assigned: Unassigned » Balu Ertl

Corrected the translatable string by inserting the missing word into the t() function at line #1567 in the webform.install file.

This is my very first patch ever submitted, so please forgive me for any mistakes I might made – all kind of feedback are appreciated.

Balu Ertl’s picture

Balu Ertl
he/him
Primary language Hungarian
Location Budapest 🇪🇺
CreditAttribution: Balu Ertl commented
Status: Active » Needs review

Excuse me, I forgot to attach the .patch file again after comment preview.

Balu Ertl’s picture

Balu Ertl
he/him
Primary language Hungarian
Location Budapest 🇪🇺
CreditAttribution: Balu Ertl commented
FileSize
2171485-webform-inserting-a-missing-word.patch0 bytes

Problems with uploading from Android, sorry.

Balu Ertl’s picture

Balu Ertl
he/him
Primary language Hungarian
Location Budapest 🇪🇺
CreditAttribution: Balu Ertl commented
FileSize
2171485-webform-inserting-a-missing-word.patch765 bytes

With Firefox now it seems promising.

quicksketch’s picture

quicksketch
he/him
CreditAttribution: quicksketch commented
Title: [Patch] Inserting a missing word into a string » Update function missing missing word for clarity
Version: 8.x-4.x-dev » 7.x-4.0-beta1
Assigned: Balu Ertl » Unassigned
Status: Needs review » Fixed

Thanks! Works for me. Committed to 7.x-4.x branch. For the 8.x-4.x version... this update will probably be removed entirely, so there's no real need to port this to 8.x-4.x.

Balu Ertl’s picture

Balu Ertl
he/him
Primary language Hungarian
Location Budapest 🇪🇺
CreditAttribution: Balu Ertl commented

Thank you quicksketch! Glad to made even such a tiny contribution to code :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
CreditAttribution: fenstrat commented
Version: 7.x-4.0-beta1 » 8.x-4.x-dev
Assigned: Unassigned » fenstrat
Status: Closed (fixed) » Patch (to be ported)

Needs porting to 8.x-4.x.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
CreditAttribution: fenstrat commented
Version: 8.x-4.x-dev » 7.x-4.0-beta1
Assigned: fenstrat » Unassigned
Status: Patch (to be ported) » Fixed

Committed and pushed 9a011c5 to 8.x-4.x. Thanks!

  • Commit cccd9da on 8.x-4.x authored by Balu Ertl, committed by fenstrat: 
    Issue #2171485 by Balu Ertl: Update function missing missing word for...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.