Validate allowed characters on project's machine name

Spaces should not be allowed.

I assume this will need a test

Here's the patch that solves the issue.
It needs a test, but since most tests are switched off for project.module, I'd rather create a followup issue for that

Project name contains incorrect symbols

The error message should be a complete sentence, with punctuation. And more friendly — what's an incorrect symbol? Should follow the function naming, from http://www.php.net/manual/en/functions.user-defined.php:

A valid function name starts with a letter or underscore, followed by any number of letters, numbers, or underscores. As a regular expression, it would be expressed thus: [a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff]*.

Validation rule and error message changed per #7.
Error message after applying patch #8:

Looks like the condition is reversed. Valid names get the error.

My bad, of course it is

Looks good. Committed & deploying.

wohoo! thanks valthebald!

Reverting because of #2227791: Project page error: Short name must follow PHP naming convention.

Let's actually move this to drupalorg. Project module should be a bit generic, it could be used for non-PHP project anyway.

This validation should run only for full projects.

Here's the patch against drupalorg

Sorry I didn't put this detail in earlier, I was in a hurry.

This should go in drupalorg_project_form_node_form_alter(), within

  if (project_node_is_project($form_state['node'])) {

The project node type shouldn't be hard-coded since modules, themes, etc are actually separate node types.

Changed per #18

Looks good. Will deploy today.

Now deployed to Drupal.org.

Glad to see this resolved, and for the validation to be in drupalorg_project, not project.module itself. It was originally discussed in #1561458: Require project node machine names to be valid Drupal module/theme machine names, but since all the Git commits point here I marked that one duplicate (even though it was the older issue).

Thanks everyone!
-Derek