ldap_authentication_user_login_authenticate_validate() can return null (line 287) and this isn't checked for in line 290 causing the following PHP Error to be thrown:

Notice: Trying to get property of non-object in ldap_sso_user_login_sso() (line 290 of /sites/all/modules/contrib/ldap/ldap_sso/ldap_sso.module).

CommentFileSizeAuthor
#1 php_notice_user_login_sso-2175881-1.patch1.05 KBAdrian Richardson

Comments

Adrian Richardson’s picture

Adrian Richardson commented
Status: Active » Needs review
StatusFileSize
new php_notice_user_login_sso-2175881-1.patch1.05 KB

Patch attached for review

johnbarclay’s picture

johnbarclay commented
Assigned: Unassigned » johnbarclay
johnbarclay’s picture

johnbarclay commented
Status: Needs review » Closed (fixed)

committed. see http://drupalcode.org/project/ldap.git/commitdiff/efc9593b812beaa52d9dee...

edog2009’s picture

edog2009 commented

I've used this patch to enable Cosign authentication with the LDAP module on a Drupal website and it works well to overcome the issue.