Compatibility with latest phirehose [#2176543]

URL_BASE is no longer a constant in Phirehose.php

/**
* @internal Moved from being a const to a variable, because some methods (user and site) need to change it.
*/
protected $URL_BASE = 'https://stream.twitter.com/1.1/statuses/';

so make line 139 of TwitterstreamPublicConsumer.php

$url = $this->URL_BASE . $this->method . '.' . $this->format;

Comment	File	Size	Author
#12	compatibility-with-latest-phirehose-2176543-12.patch	4.6 KB	ArnaudDabouis
#5	compatibility-with-latest-phirehose-2176543-4.patch	539 bytes	ArnaudDabouis
#1	2-phirehose.patch	599 bytes	ArnaudDabouis

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

ArnaudDabouis CreditAttribution: ArnaudDabouis commented 16 May 2014 at 10:21

File	Size
2-phirehose.patch	599 bytes

Comment #2

themic8 CreditAttribution: themic8 commented 7 February 2015 at 08:05

This patch didn't worked for me.

Comment #3

ArnaudDabouis CreditAttribution: ArnaudDabouis commented 5 February 2015 at 16:33

Title:

COmpatibility with latest phirehose

» Compatibility with latest phirehose

Comment #4

ArnaudDabouis CreditAttribution: ArnaudDabouis commented 9 February 2015 at 09:13

1 file was hidden/shown/deleted

File	Size
2-phirehose.patch	599 bytes

Comment #5

ArnaudDabouis CreditAttribution: ArnaudDabouis commented 9 February 2015 at 09:15

File	Size
compatibility-with-latest-phirehose-2176543-4.patch	539 bytes

This one complies with Drupal patching standards and should work.

Comment #6

themic8 CreditAttribution: themic8 commented 9 February 2015 at 11:53

I think the phirehose code has been updated and this patch is no longer valid.

Comment #7

ArnaudDabouis CreditAttribution: ArnaudDabouis commented 9 February 2015 at 13:18

Right, this patch has been done to comply with the 0.2.4 version of Phirehose. Feel free to post yours with a more up to date version of the lib.

Comment #8

themic8 CreditAttribution: themic8 commented 9 February 2015 at 13:54

Ah, that is the version you are using. The version of phirehose used is not documented anywhere.

I was unable to authenticate so I have rolled my own custom module for now.

Comment #9

ArnaudDabouis CreditAttribution: ArnaudDabouis commented 9 February 2015 at 14:31

Yes, I think the issue you have is with the fact that TwitterstreamPublicConsumer class should inherit OauthPhirehose and not Phirehose. I will write a clean patch when I find the time.