Scheduler and job scheduler

You're right, my comment is silly :)

I looked the code of your module, and I thing 1/3 of it could just disappear, the most complex one.

A nice advantage too, is that job schedule can run process periodically, imagine a news that should appear every month for instance.

Finally, by simplifying your code, it should be easier to adapt your module not only for nodes, but entities, which is in Drupal 7 or 8 very interesting

For your information: http://www.computerminds.co.uk/drupal-code/easily-scheduling-periodic-ta... shows that with a few lines, you can do magic

A rough idea:

function scheduler_entity_publish() {
  ...
}

function scheduler_entity_unpublish() {
  ...
}

function weekly_task_cron_job_scheduler_info() {
  $info = array();
  $info['scheduler_entity_publish'] = array(
    'worker callback' => 'scheduler_entity_publish',
  );
  $info['scheduler_entity_publish'] = array(
    'worker callback' => 'scheduler_entity_unpublish',
  );
  return $info;
}

function scheduler_entity_update($entity, $type) {
  $info = entity_get_info($type);
  if ($entity->publish_on) {
    $job = array(
      'name' => 'publish|' . $type . '|' . $info->bundle . '|' . $entity->id,
      'type' => 'scheduler_job',
      'period' => $node->schedule_period,
      'crontab' => '0 0 * * 0',
      'periodic' => $node->schedule_period ? TRUE : FALSE,
    );
    JobScheduler::get('scheduler_entity_publish')->set($job);
  }
  if ($entity->unpublish_on) {
    $job = array(
      'name' => 'unpublish|' . $type . '|' . $info->bundle . '|' . $entity->id,
      'type' => 'scheduler_job',
      'period' => $node->schedule_period,
      'crontab' => '0 0 * * 0',
      'periodic' => $node->schedule_period ? TRUE : FALSE,
    );
    JobScheduler::get('scheduler_entity_unpublish')->set($job);    
  }
}

Have a nice day