The view "user upcoming events" and "upcoming events" commons_events_upcoming and commons_events_user_upcoming_events does not filter on date so it can end up showing events that have already concluded. And a few other tidbits:

  1. needs to filter on event date relative to now
  2. it sorts on 'post date' whereas I think it makes more sense to post on the date of the event itself, rather than when it was posted. (I can see the argument for the former, but the latter makes more sense to me as what I and my users would expect to see.)
  3. event date is not shown at all to the user, which also seems just odd to me.
CommentFileSizeAuthor
#3 add-date-filter-2178465-3.patch3.07 KBdevin carlson

Comments

WebSinPat’s picture

WebSinPat commented

#2008596: Upcoming Events pane returning no data with in-progess events seems like it might be related but I think that was a different issue. And then in comment #4 https://drupal.org/comment/7504401#comment-7504401 @autolyst brought up what I think is this issue I am raising.

WebSinPat’s picture

WebSinPat commented
Title: User Upcoming Events shows past events » Upcoming Events shows past events
Issue summary: View changes

added commons_events_upcoming. same issue with that view as in commons_events_user_upcoming

devin carlson’s picture

devin carlson commented
Version: 7.x-3.6 » 7.x-3.x-dev
Status: Active » Needs review
Related issues: +#2008596: Upcoming Events pane returning no data with in-progess events
StatusFileSize
new add-date-filter-2178465-3.patch3.07 KB

A patch to make the sorting and filtering of the User Upcoming Events view consistent with the Upcoming Events view.

This takes care of the primary issues with the others to be addressed in #2008596: Upcoming Events pane returning no data with in-progess events.

devin carlson’s picture

devin carlson commented
Status: Needs review » Fixed

Tested #3 with an existing Commons site to verify that past events were no longer displayed and that events were listed properly by start time and not the time at which the content was created.

  • Commit 5511a11 on 7.x-3.x by Devin Carlson: 
    Issue #2178465 by Devin Carlson: Made the sorting and filtering of the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.