[meta] Variables to config migration [d7]

New version of the convert script attached with the new config plugin id.

Fixed issue where it was outputting 4 line spaces instead of 2.

Hidden mine so it doesn't confuse anyone since they're both named the same.

The current task is to ensure that the IMP sandbox contains a migration for all variables in update_variables_to_config calls in e373ebee3490120b13fb4062f37b9565e3b2474d^ or so.

An example:

  update_variables_to_config('aggregator.settings', array(
    'aggregator_fetcher' => 'fetcher',
    'aggregator_parser' => 'parser',
    'aggregator_processors' => 'processors',
    'aggregator_allowed_html_tags' => 'items.allowed_html',
    'aggregator_teaser_length' => 'items.teaser_length',
    'aggregator_clear' => 'items.expire',
    'aggregator_summary_items' => 'source.list_max',
  ));

compare to core/modules/migrate_drupal/config/install/migrate.migration.d6_aggregator_settings.yml (some might be d7 only as seen in the issue summary but most will be in the D6 files):

  variables:
    - aggregator_fetcher
    - aggregator_parser
    - aggregator_processors
    - aggregator_allowed_html_tags
    - aggregator_teaser_length
    - aggregator_clear
    - aggregator_summary_items

That's good, none are missing. If one would be missing ==> file an issue.

Here's a list of variables I found no migration for. There are enough that I wonder if I'm looking in the right place. I checked core/modules/migrate_drupal/config/install on the 8.x branch (which appears to have had the drupal7 branch merged into it). It would be good to get a reality check on this list before filing issues.

locale_translate_file_directory
menu_main_links_source
tracker_batch_size
taxonomy_maintain_index_table
cron_safe_threshold
feed_description
feed_item_length
maintenance_mode_message
cache
page_cache_maximum_age
page_compression
stale_file_threshold
menu_default_active_menus
site_default_country
date_first_day
date_default_timezone
configurable_timezones
empty_timezone_message
user_default_timezone
css_gzip_compression
js_gzip_compression
fast_404_html
fast_404_paths
fast_404_paths_exclude
allow_insecure_uploads
file_default_scheme
file_chmod_directory
file_chmod_file
file_private_path
file_temporary_path
mail_system
language_interface
language_content
language_url
filter_fallback_format
image_style_preview_image
default_nodes_main
forum_nav_vocabulary
forum_block_num_active
forum_block_num_new
update_check_disabled
update_check_frequency
update_max_fetch_time
anonymous
user_admin_role
user_register
user_signatures
user_cancel_method
user_mail_status_activated_notify
user_mail_status_blocked_notify
user_mail_status_cancelled_notify
user_email_verification
user_password_reset_timeout
register_admin_created_subject
register_admin_created_body
register_pending_approval_subject
register_pending_approval_body
register_pending_approval_admin_body
register_pending_approval_admin_subject
register_no_approval_required_subject
register_no_approval_required_body
password_reset_subject
password_reset_body
status_activated_subject
status_activated_body
status_blocked_subject
status_blocked_body
cancel_confirm_subject
cancel_confirm_body
status_canceled_subject
status_canceled_body
syslog_format
contact_threshold_limit
contact_threshold_window

Fantastic! Here's a list that need to be deleted:

Everything _body and _subject . These need a separate issue if not yet done to migrate user mail things. And I believe these were bugs, the lot of them because https://api.drupal.org/api/drupal/modules%21user%21user.module/function/... they need to be prefixed by user_mail_

locale_translate_file_directory -- this was added to D8 only and removed since.

fast_404_paths
fast_404_paths_exclude
user_mail_status_cancelled_notify -- these three according to log only ever existed in update_variables_to_config. There is no other mention of it. I even Googled fast_404_paths hoping for a contrib, a blog post or something. Nada.

language_interface -- this got removed from d7 in #282191: TF #1: Allow different interface language for the same path before release.
language_url -- ??? that never existed as a variable as far as I know. I emailed plach and Gabor Hojtsy.

Here's a list that appears in D6 too:

allow_insecure_uploads
anonymous
configurable_timezones
contact_threshold_window
date_default_timezone
date_first_day
default_nodes_main
feed_item_length
forum_nav_vocabulary
language_content
page_compression
update_check_frequency
user_email_verification
user_register
user_signatures
user_mail_status_activated_notify
user_mail_status_blocked_notify

Seems like we made a shoddy work. Thanks ksenzee!

Edit: sorry double post.

Moving this from sandbox to Core.

Hello @jcost I would like you to clarify if the tests should be written in 8.0.x-dev or in d7 but according to the author with these words "We're starting with these issues, which were postponed from D6 as they're present in D7 only:" I was thinking the tag "8.0.x-dev" should be changed

8.0.x-dev is the correct tag. These are the D7 to D8 migrations and the code will go into the 8.0.x branch

Thanks @benjy so that means D6 to D7 migrations are not what we are working on

A few of these have gone in now in the past few days:

• #2353777: Migrate Tracker module variables in D7
• #2353763: Variable to config: menu.settings [d7]
• #2409437: Migration path for Simpletest 7.x

Not 100% sure where that leaves us, though, since the issue summary is mostly pointing to "won't fix" issues atm.

According to @phenaproxima, #2456259: [META] Drupal 7 to Drupal 8 Migration path is a more up-to-date list of the remaining tasks, and it includes variable to config migrations.

Therefore, closing this one out as a duplicate.