Hi,

This morning I rolled up to v1.0 from the previous v1.0-rc2

I noticed a while later than when I logged out, a large number of nodes were hidden.

I looked at the issues, saw v1.1 so tried with that. I rebuilt permissions a number of times, but that didn't fix the problem.

Rolling back to v1.0-rc2 didn't fix the issue until I rebuilt permissions, at which stage all my nodes are correct.

I haven't found anything to determine what's causing a node to be hidden vs a node not to be. All the nodes I expected to be hidden were, but so were many that shouldn't have been.

I realise this is a rather terrible bug report, but if you can tell me what other information you'd like I'll be happy to assist.

Thanks for your work on this module, I really appreciate it.

Tim

CommentFileSizeAuthor
#10 2183179-tac_lite-terms-fix.diff1.52 KBDave Cohen
#3 perms.PNG60.37 KBtjharman

Comments

Dave Cohen’s picture

Dave Cohen commented

Try version 1.1. There was a problem with 1.0, although you should have seen some errors if you encountered that problem.

Also try the devel_node_access module to help troubleshoot. It's part of devel.module.

tjharman’s picture

tjharman commented

Still hitting the same issue.

If I upgrade from v1.0rc2 -> 1.1 straight away, everything seems to work.

But if I rebuild permissions, I get the mysterious nodes-not-appearing issue.

With the devel module enabled, I see the following:

For v1.0rc2 on a "broken" node:

username: Anonymous
Create: NO: No reason
view: YES {node_access}
Update: NO: No reason
Delete: NO: No reason

For v1.1 on the same node:

username: Anonymous
Create: NO: No reason
view: NO: No reason
Update: NO: No reason
Delete: NO: No reason

I also see the following: Image of Tables (This is the same node as used for the tables above)

The node in question does not have any taxonomy to restrict its ability to be viewed. I am rebuilding permissions every time I swap between the v1.1 and v1.0rc2

The other thing I've noticed:
On the status page where you rebuild permissions, after a rebuild with v1.1 I see "6637 permissions in use"
With v1.0rc2 I see "2527 permissions in use"

I hope this helps?

Tim

tjharman’s picture

tjharman commented
StatusFileSize
new perms.PNG60.37 KB
Dave Cohen’s picture

Dave Cohen commented

I'm quite confused.

You said "For v1.0rc2 on a "broken" node" Are nodes broken on 1.0rc2? Your original post implied that's where they work.

Are there 6637 terms total? Is the "broken" node tagged with 2527 terms?

Dave Cohen’s picture

Dave Cohen commented

What happens if you simply save a "broken" node? Instead of rebuilding all permissions, just save the node. Then does tac_lite get the node_access table right?

tjharman’s picture

tjharman commented

I'm sorry, I'll try and clarify, you're right my wording is rather terrible.

In v1.0-rc2 everything works correctly. If I mark a node with my "Private" taxonomy, it's hidden to all users except those with permission to view.

When upgrading to v1.1, some nodes are hidden for anonymous users that should be (and with v1.0-rc2 are) visible to them - they are unmarked by the Taxonomy used to hide nodes. However some nodes are still visible and they too are unmarked by the Taxonomy used to hide nodes. I can't figure out what the difference is between an affected and unaffected node. Note that all nodes that should be hidden are, it's just there are many nodes that shouldn't be hidden that also are.

One such node, my latest post, is node ID 2593. My usage of the term "broken node" was mean to refer to a node that is visible with v1.0-rc2 but not with v1.1. A much better term would have been "affected node". That is a node that is hidden when it shouldn't be with v1.1

I have approximately ~2593 nodes (some have been deleted over time) on my site. I presume that where we see "2527 permissions in use" that means there are 2593 minus 2527 nodes hidden, approx 66 nodes that are marked with the Taxonomy used to hide nodes. That would seem about right to me, though I haven't counted.

I hope this helps?

(I am more happy to give you full access to my site if you feel that would help you resolve the issue quicker)

tjharman’s picture

tjharman commented

Saving an affected node hasn't changed the situation - it is still hidden from me if I'm not logged in.

A node that isn't affected by this issue has these permissions. Should that ' be there?

tjharman’s picture

tjharman commented

I've done some more testing.

It seems that nodes tagged with any Taxonomy are hidden.

The nodes that remain visible are ones where I haven't tagged them at all.

I don't just mean the tac_lite taxnomoy I'm using, but even just the free-tagging taxonomy. Put a term in there and the node becomes hidden.

Dave Cohen’s picture

Dave Cohen commented

It seems that nodes tagged with any Taxonomy are hidden.

Thanks for that clue. Now I can reproduce it. I'll get a fix asap.

Dave Cohen’s picture

Dave Cohen commented
Status: Active » Needs review
StatusFileSize
new 2183179-tac_lite-terms-fix.diff1.52 KB

I'm confident this fixes it. Pushed to .dev already.

tjharman’s picture

tjharman commented

Hi Dave,

Thanks very much. I can confirm the patch in #10 fixes the issue.

Cheers,
Tim

Dave Cohen’s picture

Dave Cohen commented
Assigned: Unassigned » Dave Cohen
Status: Needs review » Fixed

thanks for the quick reply. And the detailed report.

I'm making a 1.2 build with the fix.

tjharman’s picture

tjharman commented

The warning can probably be moved off the project page now, 1.2 seems to work just fine.

Dave Cohen’s picture

Dave Cohen commented

Thanks for reminding me.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.