Closed (fixed)
Project:
Panels
Version:
6.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
29 Jan 2014 at 05:14 UTC
Updated:
10 Dec 2015 at 08:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
damienmckennaComment #2
damienmckennaWould this work? It adds the new cache table and updates the Simple Cache plugin.
Comment #3
japerrymarking needs work. I cannot seem to be able to clear cache from views. The created timestamp doesn't change when I run drush cc all.
Comment #4
damienmckennaIt probably needs an implementation of hook_flush_caches.
Comment #5
damienmckennaWith hook_flush_caches.
Comment #7
damienmckennaRerolled.
Comment #9
damienmckennaReroll?
Comment #10
damienmckennaThe tests worked! #fistpump
Comment #11
japerryIts useful to do panels_flush_caches instead of hook_flush_caches.
I've re-tested against this change and my tests pass. And we're good!
Committed: http://drupalcode.org/project/panels.git/commit/599d24e
Comment #12
damienmckennaOH ffs Damien, you twit. X-)
Thanks japerry!
Comment #13
damienmckennaMind if I reroll this for D6?
Comment #14
damienmckennaComment #15
damienmckennaD6 version, as promised.
Comment #18
damienmckennaThere is no test suite for D6, so putting this back to 'needs review'.
Comment #19
star-szrFor what it's worth, there is what looks like a legitimate error pointed out by testbot:
Fatal error: Cannot redeclare panels_flush_caches() (previously declared in ./sites/default/modules/panels/panels.module:31) in ./sites/default/modules/panels/panels.module on line 291Comment #20
damienmckenna@cottser: Testbot can't test a patch that has already been committed, that error is redundant.
Comment #21
star-szrI mean the D6 patch, which looks like it hasn't been committed yet. If it's committed we can close this issue, right?
Comment #22
damienmckenna@cottser: Ah, I'm sorry. Here's an updated patch that fixes that problem.
Comment #23
star-szrLooks good to me :)
Edit: I reviewed and compared it to the D7 patch, I didn't do any manual testing.
Comment #24
damienmckennaComment #25
intrafusionPatch updated, looks like db_create_table() has changed at some point
Comment #27
intrafusionRe-rolled patch
Comment #28
damienmckenna@intrafusion: Thanks for catching that bug with db_create_table!
Comment #29
japerryTested, looks good to me. Committed!