from the POV of performance optimization, it'd be useful if there was a custom cache table for Panels, rather than Simple Cache using the base 'cache' table. Were this done, all of the custom Panels cache modules could then use this table rather than each one creating their own.

Comments

damienmckenna’s picture

damienmckenna’s picture

Status: Active » Needs review
StatusFileSize
new1.71 KB

Would this work? It adds the new cache table and updates the Simple Cache plugin.

japerry’s picture

Status: Needs review » Needs work

marking needs work. I cannot seem to be able to clear cache from views. The created timestamp doesn't change when I run drush cc all.

damienmckenna’s picture

It probably needs an implementation of hook_flush_caches.

damienmckenna’s picture

Status: Needs work » Needs review
StatusFileSize
new2.09 KB

With hook_flush_caches.

Status: Needs review » Needs work

The last submitted patch, 5: panels-n2184143-5.patch, failed testing.

damienmckenna’s picture

Status: Needs work » Needs review
StatusFileSize
new2.09 KB

Rerolled.

Status: Needs review » Needs work

The last submitted patch, 7: panels-n2184143-5.patch, failed testing.

damienmckenna’s picture

Status: Needs work » Needs review
StatusFileSize
new2.09 KB

Reroll?

damienmckenna’s picture

The tests worked! #fistpump

japerry’s picture

Status: Needs review » Fixed
+++ b/panels.module
@@ -27,6 +27,13 @@ function panels_api_version() {
+function hook_flush_caches() {
+  return array('cache_panels');
+}

Its useful to do panels_flush_caches instead of hook_flush_caches.

I've re-tested against this change and my tests pass. And we're good!

Committed: http://drupalcode.org/project/panels.git/commit/599d24e

damienmckenna’s picture

OH ffs Damien, you twit. X-)

Thanks japerry!

damienmckenna’s picture

Version: 7.x-3.x-dev » 6.x-3.x-dev
Status: Fixed » Patch (to be ported)

Mind if I reroll this for D6?

damienmckenna’s picture

damienmckenna’s picture

Status: Patch (to be ported) » Needs review
StatusFileSize
new2.09 KB

D6 version, as promised.

Status: Needs review » Needs work

The last submitted patch, 15: panels-n2184143-15.patch, failed testing.

  • Commit 599d24e on 7.x-3.x, 8.x-3.x authored by DamienMcKenna, committed by japerry:
    Issue #2184143 DamienMcKenna, japerry: define explicit panels cache...
damienmckenna’s picture

Status: Needs work » Needs review

There is no test suite for D6, so putting this back to 'needs review'.

star-szr’s picture

Status: Needs review » Needs work

For what it's worth, there is what looks like a legitimate error pointed out by testbot:

Fatal error: Cannot redeclare panels_flush_caches() (previously declared in ./sites/default/modules/panels/panels.module:31) in ./sites/default/modules/panels/panels.module on line 291

damienmckenna’s picture

@cottser: Testbot can't test a patch that has already been committed, that error is redundant.

star-szr’s picture

I mean the D6 patch, which looks like it hasn't been committed yet. If it's committed we can close this issue, right?

damienmckenna’s picture

Status: Needs work » Needs review
StatusFileSize
new2.38 KB

@cottser: Ah, I'm sorry. Here's an updated patch that fixes that problem.

star-szr’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me :)

Edit: I reviewed and compared it to the D7 patch, I didn't do any manual testing.

damienmckenna’s picture

intrafusion’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new2.4 KB

Patch updated, looks like db_create_table() has changed at some point

Status: Needs review » Needs work

The last submitted patch, 25: panels-n2184143-25-d6.patch, failed testing.

intrafusion’s picture

Status: Needs work » Needs review
StatusFileSize
new2.41 KB

Re-rolled patch

damienmckenna’s picture

@intrafusion: Thanks for catching that bug with db_create_table!

japerry’s picture

Status: Needs review » Fixed

Tested, looks good to me. Committed!

  • japerry committed bd1edc2 on 6.x-3.x authored by intrafusion
    Issue #2184143 by DamienMcKenna, intrafusion: Add a Panels cache table
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.