[D7] Computed field order

Hi @ssoulless

Please add link to your git repository.

I found issue in computed_field_order.info.
dependencies = computed_field
should be
dependencies[] = computed_field

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxssoulless2187993git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,

Just fix the issues and commit it and update the same issue with "Needs reviews" state.

Also add the "git clone" command in issue summary.

Also please take care of the following:
In module file, line 106,
"admin/config/content/computed_field_order/$row->entity_type/"

It can be better if you use the variables out of double quotes using concatenation.

Thanks

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Manual review of the 7.x-1.x branch:

The git clone command should be "git clone --branch 7.x-1.x http://git.drupal.org/sandbox/ssoulless/2187993.git computed_field_order" as it appears in your sandbox. The command you have given is for you, with maintainer access.

computed_field_order.module

• line 10 : Error: Undefined variable info

@ssoulless, first of all thankyou for your contribution.

Manual Review
1. (*) You have keep all your code inside .module file, for configuration form create one separate file something like computed_field_order.admin.inc.
2. I installed your module and access the admin/config/content/computed_field_order page but as I don't have added any computed field so no bundle is appearing there. But it is still showing Click on a bundle name to expose the computed fields for that bundle.. I think this message should appear when $items count is > 0.
3. After this I created one computed field inside article content type and access this page, it is still showing me same screen without any change. Then I manually check admin/config/content/computed_field_order/node/article page, it showed me computed field. It need to be fixed as end user not able to understand how computed field would appear.
4. Let me check by adding one more computed field in page content type, now its a strange issue it is appearing as:

Let me check your $item array,

Array
(
    [node] => Array
        (
            [data] => Node
            [children] => Array
                (
                    [page] => Array
                        (
                            [data] => Basic page
                            [class] => Array
                                (
                                    [0] => computed_field_order
                                    [1] => node
                                    [2] => page
                                )

                        )

                )

        )

)

Strange, it also showing me only one content type name i.e page. Article content type still not in array.

Interesting, I need to debug your code because I am still able to see computed field in Article content type. There is some major logic failure in following code. Every time first it goes to else statement because $items array is always empty and inside your else statement there is no link added for bundle. This is the problem that you need to fix in a good manner because your first element always skipped due to this else statement.

foreach ($result as $row) {
    // Build a multi-level list.
    if (isset($items[$row->entity_type])) {
      $classes = array(
        'computed_field_order',                // Standard class
        drupal_html_class($row->entity_type),  // and entity_type
        drupal_html_class($row->bundle),       // and bundle.
        );

      // It was serendipitous, but using the bundle name as a key prevents duplicates.
      // using Distinct in the query resulted in missed data.
      $items[$row->entity_type]['children'][$row->bundle] = array(
        'data' => l($info['bundles'][$row->bundle]['label'],
          "admin/config/content/computed_field_order/" . $row->entity_type . "/" . $row->bundle),
        'class' => $classes,
        );
    }
    else {
      $info = entity_get_info($row->entity_type);
      $items[$row->entity_type] = array(
        'data' => check_plain($info['label']),
        'children' => array(),
        );
    }
  }

Anyways, thankyou for your hardwork :)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.