Rename EntityStorageController to EntityStorage

I'll take a stab at this.

Some progress, I have a test site up and running again after the great rename. Tomorrow I'll weed out some failing tests.

I'm getting some very weird fallout on the tests, that doesn't make much sense. Aggregator fails on feed items never hitting the DB, but entity tests passes. drupal_render and readonly stream wrappers fails.

I have to dig deeper to figure out what goes wrong here..

Now that was stupid. twig_debug in settings file killing random tests.

Let's see what the testbot thinks.

Damn, this is virtually impossible to keep up to date with HEAD. Two days, and there's merge conflicts in 26 files.

Well, #2165155: Change $entity_type to $entity_type_id and $entity_info to $entity_type/$entity_types just got in, which changed all the constructor arguments.

That said, looks like your patch does not correctly move the files but deletes and re-adds all content, make sure you have git configured properly, the patch should *not* be almost 1MB :)

You should be able to do the merge by applying on an older version and then rebasing/merging with head, I'd expect that might work for most conflicts.

@berdir
Ah, yes that'll explain it.

Which git configuration is that?

Well, the 26 files is in rebasing, mostly the mentioned constructors.

Rebasing as we speak...

OK, rerolled.

Woops, and status.

Now that's some odd errors. Token fails?

I'll look into it later.

Fixed the failing tests and re-rolled.

Very nice work!

Here's a re-roll, tons of conflicts and a few new replacements. Also found a new pattern to replace $this->storageController => $this->storage. somethingStorage or entityStorage might be better, not sure.

Ups.

Re-roll and new replacement pattern: "storage controller" => "storage". We however sometimes also refer to config/extension storage as storage controller...

Fixed some left-over storageController property usage.

Needs reroll. But that may need to wait until #2120871: Rename EntityListController to EntityListBuilder gets committed.

Working on a re-roll.

Ok, let's try how this goes.

Yeah, sorry, I forgot.

We discussed it and we're going to schedule the commit during the next few days, meaning we'll time the re-roll, review and then commit it asap.

Another re-roll. I don't think the sandbox helps because there aren't multiple people working on it, just re-rolls. And I prefer doing those with rebase.

You shouldn't be re-rolling this patch against an old HEAD :)

And one more...

Ok, here is another update that renames the following classes as discussed (already based on the renames we're already doing):

FieldableEntityStorageInterface => ExtendableEntityStorageInterface
FieldableEntityStorageBase => ContentEntityStorageBase
FieldableDatabaseEntityStorage => ContentEntityDatabaseStorage
DatabaseEntityStorage => EntityDatabaseStorage

I've also made nice pictures of the before after.

Before:

After:

And.. another re-roll.

One file didn't get renamed. Also found FieldableNullStorage and renamed that too to ContentEntityNullStorage which makes much more sense.

Too late to work on something like this.

s/Extendable/Extensible? Not sure that extendable is really a word.
Also that interface has no docblock, so it's hard to tell what it's for.

Re-roll, clean-up, fixing tests. Not sure where that text summary change was coming from, reverted, doesn't belong in here.

https://english.stackexchange.com/questions/90426/extensible-vs-extendible

I use the terms as Jim does in the context of Computer Science. In a computer program, if I add subroutines or blocks it is extendable - I can add more blocks. If the program is extensible, the individual blocks may be made more complex by modification, usually adding flexibility.

So this seems Extensible

Ok, after quite some discussion with @alexpott, we decided to *not* rename the interface. The initial argument for doing it here that it would affect a lot of places, but with the actual implementations renamed to ContentEntity*, which makes a lot of sense and everyone agrees with I think, renaming the interface becomes a trivial task (see interdiff) and can be discussed in #2100343: Remove 'fieldable' key in entity definitions in favour of 'field_ui_base_route'.

Great - let's proceed. I've read the patch and checked that all the old names are not appearing in HEAD anywhere.

Committed/pushed to 8.x, thanks!

For posterity, here is the "before" with its filename fixed.

For info. I've created this issue to remove some remaining references to Entity Storage Controller (mainly in comments): #2248051: Remove last references to Entity Storage Controller